Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong location in quotations #4357

Closed
vicuna opened this issue Aug 5, 2007 · 2 comments
Closed

Wrong location in quotations #4357

vicuna opened this issue Aug 5, 2007 · 2 comments
Labels
bug camlp4

Comments

@vicuna
Copy link

vicuna commented Aug 5, 2007

Original bug ID: 4357
Reporter: gerd
Assigned to: ertai
Status: closed (set by @xavierleroy on 2010-04-29T12:26:04Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.10.0
Fixed in version: 3.10+dev
Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues

Bug description

The start offset of locations passed to quotation expanders seem to be wrong. See the attached files. If err.cmo is applied to errsample.ml, it prints to stderr

file=errsample.ml line=2 offset=37 bol=18

However, offset=35 would be correct.

File attachments
@vicuna
Copy link
Author

vicuna commented Aug 5, 2007

Comment author: gerd

Also checked that in the release310 branch. It is still incorrect there.

@vicuna
Copy link
Author

vicuna commented Nov 27, 2007

Comment author: ertai

Thanks for the report. This is now fixed in the CVS (both in trunk and release310 branch).

@vicuna vicuna closed this as completed Apr 29, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug camlp4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vicuna