Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMake fails to build with release candidate #4470

Closed
vicuna opened this issue Dec 21, 2007 · 1 comment
Closed

OMake fails to build with release candidate #4470

vicuna opened this issue Dec 21, 2007 · 1 comment
Assignees
Labels

Comments

@vicuna
Copy link

vicuna commented Dec 21, 2007

Original bug ID: 4470
Reporter: @mmottl
Assigned to: @xavierleroy
Status: closed (set by @xavierleroy on 2010-04-29T12:26:01Z)
Resolution: fixed
Priority: normal
Severity: major
Version: 3.10+dev
Category: ~DO NOT USE (was: OCaml general)
Related to: #4615
Monitored by: heidegger @mmottl

Bug description

I have run into the following problem trying to build omake-9.8.5.godi3 in Godi with the current release candidate 1 for OCaml-3.10.1. According to the developers this seems to be related to the typing of recursive modules. Could the OCaml-team please investigate this problem before making the release? - Thanks!

File "omake_node.ml", line 331, characters 0-791:
Signature mismatch:
Modules do not match:
sig
type t =
DirElt.t =
DirRoot of Lm_filename_util.root
| DirSub of FileCase.t * string * t Lm_hash.hash_marshal_eq_item
val abs_dir_name : DirHash.t -> string
end
is not included in
sig
type t =
DirRoot of Lm_filename_util.root
| DirSub of FileCase.t * string * DirHash.t
val abs_dir_name : DirHash.t -> string
end
Type declarations do not match:
type t =
DirElt.t =
DirRoot of Lm_filename_util.root
| DirSub of FileCase.t * string * t Lm_hash.hash_marshal_eq_item
is not included in
type t =
DirRoot of Lm_filename_util.root
| DirSub of FileCase.t * string * DirHash.t
make[1]: *** [omake_node.cmo] Error 2
make: *** [bootstrap] Error 2
make[1]: Leaving directory `/usr/local/home/godi310.1_64bit/godi/build/godi/godi-omake/work/omake-0.9.8.5/boot'

@vicuna
Copy link
Author

vicuna commented Dec 26, 2007

Comment author: @xavierleroy

Many thanks for this interesting bug report. Another user reported a similar problem on a different body of code. The type-checking of recursive modules was unsound in 3.10.0, but too strict in 3.10.1rc1. I refined the typing criterion in the 3.10 CVS branch in a way that remains sound but correctly accepts OMake and the other example. The criterion is probably still incomplete, but we'll see if it is good enough in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants