Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of empty elements from quotations #4526

Closed
vicuna opened this issue Apr 1, 2008 · 2 comments
Closed

get rid of empty elements from quotations #4526

vicuna opened this issue Apr 1, 2008 · 2 comments

Comments

@vicuna
Copy link

vicuna commented Apr 1, 2008

Original bug ID: 4526
Reporter: hirokawa
Assigned to: @bobzhang
Status: closed (set by @xavierleroy on 2015-12-11T18:21:12Z)
Resolution: not a bug
Priority: normal
Severity: feature
Version: 3.10.2
Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues
Monitored by: hirokawa

Bug description

(from caml-list)
It would be nice if <:str_item< .. >> and <:sig_item< .. >>
generate no redundant nil constructors like SgNil.
The current camlp4o generates redundant nils: for instance,

% cat a.ml
<:sig_item< type t >>

% camlp4of a.ml
Ast.SgSem (_loc,
Ast.SgTyp (_loc, Ast.TyDcl (_loc, "t", [], Ast.TyNil _loc, [])),
Ast.SgNil _loc)

Attached is a patch for that.

File attachments

@vicuna
Copy link
Author

vicuna commented Aug 22, 2012

Comment author: @bobzhang

Should this be closed? I can not reproduce it anymore

@vicuna
Copy link
Author

vicuna commented Jul 28, 2013

Comment author: @bobzhang

since I could not reproduce the behavior, I closed the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant