Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options.ext_dll is always "so" #4720

Closed
vicuna opened this issue Feb 19, 2009 · 1 comment
Closed

Options.ext_dll is always "so" #4720

vicuna opened this issue Feb 19, 2009 · 1 comment

Comments

@vicuna
Copy link

vicuna commented Feb 19, 2009

Original bug ID: 4720
Reporter: matt
Assigned to: ertai
Status: closed (set by @xavierleroy on 2011-05-29T10:20:02Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.11.0
Fixed in version: 3.11.2+dev
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Monitored by: @ygrek

Bug description

This leads to unnecessary rebuild (targets that are producing dlls).

Workaround:

Add

let () = if Sys.os_type = "Win32" then Options.ext_dll := "dll"

in myocamlbuild.ml

Additional information

Patch attempt. A cleaner solution would certainly to read ext_dll from a file produced by ./configure

--- a/ocamlbuild/options.ml
+++ b/ocamlbuild/options.ml
@@ -78,7 +78,7 @@ let show_documentation = ref false
let recursive = ref false
let ext_lib = ref "a"
let ext_obj = ref "o"
-let ext_dll = ref "so"
+let ext_dll = ref (if Sys.os_type = "Win32" then "dll" else "so")

let targets_internal = ref []
let ocaml_libs_internal = ref []

Salutations

@vicuna
Copy link
Author

vicuna commented Mar 25, 2009

Comment author: @ygrek

I think the same applies to ext_lib and ext_obj - it will simplify building bindings with ocaml/msvc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant