Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error propagation #4757

Closed
vicuna opened this issue Mar 27, 2009 · 1 comment
Closed

Error propagation #4757

vicuna opened this issue Mar 27, 2009 · 1 comment

Comments

@vicuna
Copy link

vicuna commented Mar 27, 2009

Original bug ID: 4757
Reporter: artemis01
Assigned to: @alainfrisch
Status: resolved (set by @alainfrisch on 2016-12-07T17:28:08Z)
Resolution: won't fix
Priority: normal
Severity: feature
Version: 3.11.0
Category: standard library

Bug description

In the standard library, module String.

When the String.make's call to String.create raises Invalid_argument, the error message is "Exception: Invalid_argument "String.create"."

It would be better if it were "Exception: Invalid_argument "String.make"." in order to find where the error comes from.

Thanks.

@vicuna
Copy link
Author

vicuna commented Dec 7, 2016

Comment author: @alainfrisch

The same would need to be done for all other functions in String/Bytes calling create. This would introduce some overhead (if we add an exception wrapper or reimplement the bound checks in each function), and the backtrace is a better way to find out the problem. Changing the text now could in theory break existing code (although it is explicitly discouraged to match on the concrete string). Anyway, given the lack of activity of this ticket for many years, I'm marking it as "won't fix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants