Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Unix.create_process not working properly from a Cygwin shell #4809

Closed
vicuna opened this issue May 28, 2009 · 1 comment
Closed
Labels

Comments

@vicuna
Copy link

vicuna commented May 28, 2009

Original bug ID: 4809
Reporter: vouillon
Status: closed (set by @xavierleroy on 2009-06-03T08:45:40Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.11.0
Fixed in version: 3.11.1+dev
Category: ~DO NOT USE (was: OCaml general)

Bug description

When Unison is started from a Cygwin shell, it fails to start an ssh subprocess (calling Unix.create_process). The reason is that wrong startup information is passed to the ssh subprocess.

Changing the line:
GetStartupInfo(&si);
to:
ZeroMemory(&si, sizeof(STARTUPINFO));
si.cb = sizeof(STARTUPINFO);
in file createprocess.c fixes the problem. By the way, this is what the Microsoft CRT library does.

At least, field si.cbReserved2 should be set to 0 and field si.lpReserved2 should be set to NULL, as documented at:
http://msdn.microsoft.com/en-us/library/ms686331(VS.85).aspx

@vicuna
Copy link
Author

vicuna commented Jun 3, 2009

Comment author: @xavierleroy

Thanks for pointing out this issue. The suggested fix was applied in the "release311" branch and will be part of release 3.11.1

@vicuna vicuna closed this as completed Jun 3, 2009
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant