Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect removals of unescaped end-of-lines in OCaml sources #5146

Closed
vicuna opened this issue Sep 15, 2010 · 1 comment
Closed

Incorrect removals of unescaped end-of-lines in OCaml sources #5146

vicuna opened this issue Sep 15, 2010 · 1 comment
Labels
bug

Comments

@vicuna
Copy link

vicuna commented Sep 15, 2010

Original bug ID: 5146
Reporter: @glondu
Status: closed (set by @damiendoligez on 2010-09-29T16:47:39Z)
Resolution: fixed
Priority: normal
Severity: tweak
Version: 3.12.0
Fixed in version: 3.12.1+dev
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @hcarty

Bug description

Hello,

SVN commit 9512 adds the unescaped end-of-line warning, and removes at the same time the ones occurring in OCaml sources, by putting "\n" before end-of-lines in string litterals.

This is incorrect when the following line starts with spaces... For example, with OCaml 3.12, everything is flushed to the left in "ocamlmklib -h" output.

I suggest using "\n" at the beginning of the next line instead, as done in the attached patch.

File attachments
@vicuna
Copy link
Author

vicuna commented Sep 29, 2010

Comment author: @damiendoligez

I applied your patch. Another solution would be to add a backslash at the beginning of the next line.

@vicuna vicuna closed this as completed Sep 29, 2010
@vicuna vicuna added the bug label Mar 20, 2019
@dra27 dra27 mentioned this issue Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vicuna