Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0005146OCaml~DO NOT USE (was: OCaml general)public2010-09-15 13:252010-09-29 18:47
Assigned To 
PlatformOSOS Version
Product Version3.12.0 
Target VersionFixed in Version3.12.1+dev 
Summary0005146: Incorrect removals of unescaped end-of-lines in OCaml sources

SVN commit 9512 adds the unescaped end-of-line warning, and removes at the same time the ones occurring in OCaml sources, by putting "\n\" before end-of-lines in string litterals.

This is incorrect when the following line starts with spaces... For example, with OCaml 3.12, everything is flushed to the left in "ocamlmklib -h" output.

I suggest using "\n" at the beginning of the next line instead, as done in the attached patch.
TagsNo tags attached.
Attached Filespatch file icon ocaml-end-of-line.patch [^] (18,029 bytes) 2010-09-15 13:25 [Show Content]

- Relationships

-  Notes
doligez (administrator)
2010-09-29 18:47

I applied your patch. Another solution would be to add a backslash at the beginning of the next line.

- Issue History
Date Modified Username Field Change
2010-09-15 13:25 glondu New Issue
2010-09-15 13:25 glondu File Added: ocaml-end-of-line.patch
2010-09-29 18:47 doligez Note Added: 0005666
2010-09-29 18:47 doligez Status new => closed
2010-09-29 18:47 doligez Resolution open => fixed
2010-09-29 18:47 doligez Fixed in Version => 3.12.1+dev
2017-02-23 16:36 doligez Category OCaml general => -OCaml general
2017-03-03 17:55 doligez Category -OCaml general => -(deprecated) general
2017-03-03 18:01 doligez Category -(deprecated) general => ~deprecated (was: OCaml general)
2017-03-06 17:04 doligez Category ~deprecated (was: OCaml general) => ~DO NOT USE (was: OCaml general)

Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker