Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caml_convert_signal_number/caml_rev_convert_signal_number should not be private in caml/signals.h #5157

Closed
vicuna opened this issue Sep 27, 2010 · 2 comments
Assignees

Comments

@vicuna
Copy link

vicuna commented Sep 27, 2010

Original bug ID: 5157
Reporter: kaustuv
Assigned to: @mshinwell
Status: resolved (set by @mshinwell on 2016-12-07T16:39:48Z)
Resolution: fixed
Priority: normal
Severity: feature
Version: 3.12.0
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @ygrek @glondu @hcarty @dbuenzli

Bug description

There is apparently no way to go back and forth between the signal numbers defined in the Sys module and native signal numbers without breaking the caml API. This prevents the Unix module from being cleanly extended with non-POSIX signal operations, such as adding support for signalfd(2) on Linux.

File attachments

@vicuna
Copy link
Author

vicuna commented Feb 6, 2014

Comment author: kaustuv

This seems to have dropped off the radar. I just recently ran into this problem again when I had to bind a C library that does signal munging of its own. The fix is almost too trivial for words, but I've attached a patch nonetheless.

I understand that changing the caml api should not be done lightly as you limit your options for changes in the future. However, this particular feature of signals.h has been stable for a very long time.

@vicuna
Copy link
Author

vicuna commented Dec 7, 2016

Comment author: @mshinwell

The relevant functions may now be got at using CAML_INTERNALS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants