Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions raised by Genlex token streams should be more meaningful #5189

Closed
vicuna opened this issue Dec 8, 2010 · 1 comment
Closed

Exceptions raised by Genlex token streams should be more meaningful #5189

vicuna opened this issue Dec 8, 2010 · 1 comment

Comments

@vicuna
Copy link

vicuna commented Dec 8, 2010

Original bug ID: 5189
Reporter: kim
Status: acknowledged (set by @damiendoligez on 2011-05-17T15:36:01Z)
Resolution: open
Priority: normal
Severity: feature
Version: 3.12.1+dev
Category: standard library

Bug description

Whenever the lexed stream contains invalid character tokens,
invalid strings or invalid escape sequences, Stream.next and Stream.peek raise
'Stream.Error("")'
The message attached to the exception should be more meaningful to allow the programmer to distinguish between the cases (invalid character, invalid string,...)

Additional information

I use Genlex from within ocamlbuild to fetch files that are INCLUDEd (with the pa_macro extension) and add them dynamically as dependencies. The Genlex generated lexer fails on type expressions with variables, e.g. 'a t since it detects 'a as malformed char expression.

@github-actions
Copy link

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant