Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wosize vs. real size in comballoc.ml #5192

Closed
vicuna opened this issue Dec 9, 2010 · 1 comment
Closed

wosize vs. real size in comballoc.ml #5192

vicuna opened this issue Dec 9, 2010 · 1 comment
Assignees
@xavierleroy
Labels
bug

Comments

@vicuna
Copy link

vicuna commented Dec 9, 2010

Original bug ID: 5192
Reporter: meurer
Assigned to: @xavierleroy
Status: closed (set by @xavierleroy on 2012-03-24T14:01:40Z)
Resolution: fixed
Priority: normal
Severity: trivial
Version: 3.12.1+dev
Fixed in version: 3.12.1+dev
Category: ~DO NOT USE (was: OCaml general)

Bug description

There is probably a typo in comballoc.ml; when combining subsequent allocations, the real size (in bytes) is compared to Config.max_young_wosize (in words). See attached patch.

File attachments
@vicuna
Copy link
Author

vicuna commented Dec 22, 2010

Comment author: @xavierleroy

Well spotted, thanks. You are correct that sizes are counted in bytes in Comballoc and throughout the OCaml back-end. Patch applied in bugfix branch 3.12, will go in release 3.12.1.

@vicuna vicuna closed this as completed Mar 24, 2012
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xavierleroy xavierleroy

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xavierleroy @vicuna