Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error in asmcomp/alpha/proc.ml #5207

Closed
vicuna opened this issue Jan 20, 2011 · 1 comment
Closed

Syntax error in asmcomp/alpha/proc.ml #5207

vicuna opened this issue Jan 20, 2011 · 1 comment

Comments

@vicuna
Copy link

vicuna commented Jan 20, 2011

Original bug ID: 5207
Reporter: ofalk
Status: closed (set by @damiendoligez on 2011-01-21T13:21:03Z)
Resolution: fixed
Priority: normal
Severity: trivial
Version: 3.11.0
Fixed in version: 3.12.0
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Duplicate of: #4971

Bug description

While trying to compile ocaml 3.11.0 (and even later) it spots a syntax error in line 211.
The actual code:
let assemble_file infile outfile =
let as_cmd =
if digital_asm && !Clflags.gprofile
then Config.as ^ " -pg"
else Config.as in
Ccomp.command (as_cmd ^ " -o " ^
Filename.quote outfile ^ " " ^ Filename.quote infile)

So something is wrong with this line: then Config.as ^ " -pg"
I'm not a ocaml guy... I'm just trying to compile it... But I guess there's something wrong with the quoting...

Replacing the code with:
let assemble_file infile outfile =
Ccomp.command (Config.asm ^ " -o " ^ Filename.quote outfile ^ " " ^ Filename.quote infile)

seems to work fine.

@vicuna
Copy link
Author

vicuna commented Jan 21, 2011

Comment author: @damiendoligez

"as" is a keyword. Both occurrences of "Config.as" should be replaced by "Config.asm".

This is already fixed in 3.12.0 and later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant