Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

natdynlink not built because configure contains an incorrect test for FreeBSD #5209

Closed
vicuna opened this issue Jan 25, 2011 · 1 comment
Closed
Labels

Comments

@vicuna
Copy link

vicuna commented Jan 25, 2011

Original bug ID: 5209
Reporter: @dra27
Assigned to: @xclerc
Status: closed (set by @xavierleroy on 2012-09-25T18:06:17Z)
Resolution: fixed
Priority: normal
Severity: block
Version: 3.12.0
Fixed in version: 3.12.1+dev
Category: ~DO NOT USE (was: OCaml general)
Related to: #5273

Bug description

The test for FreeBSD for natdynlink support in OCaml's configure script seems to be incorrect. I don't know why the cases contain a 'k' or why i386 (the default name for x86) is not included. Is kfreebsd ever a correct symbol? Removing it and allowing 386 allows successful use of natdynlink on FreeBSD 8.1 (a simple test works as well).

This bug would seem to have been introduced with 3.12.0 (the version of configure in 3.11.2 doesn't do this which is presumably why the BSD port maintainer hasn't reported a bug...)

Additional information

The line numbers aren't correct (I'd changed some other things in configure) but the context should be enough:

@@ -626,8 +639,9 @@
i[3456]86--darwin[89]) natdynlink=true;;
powerpc64--linux) natdynlink=true;;
sparc--linux) natdynlink=true;;

  • i686--kfreebsd) natdynlink=true;;
  • x86_64--kfreebsd) natdynlink=true;;
  • i[36]86--freebsd) natdynlink=true;;
  • x86_64--freebsd) natdynlink=true;;
    i386-*-gnu0.3) natdynlink=true;;
    esac
    fi
@vicuna
Copy link
Author

vicuna commented Feb 21, 2011

Comment author: @xclerc

fix tested on a 'real' NetBSD instance, and on a 'virtualized' FreeBSD instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant