You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Original bug ID: 5504 Reporter:@glondu Assigned to: meyer Status: closed (set by @xavierleroy on 2013-08-31T10:46:38Z) Resolution: fixed Priority: normal Severity: minor Fixed in version: 3.13.0+dev Category: ~DO NOT USE (was: OCaml general) Monitored by: meyer mehdi @damiendoligez
Bug description
They uselessly clutter diffs against release tarballs, making reviewing more difficult for almost no benefit.
They can also lead to errors such as committing unwanted changes. See the attached patch (against 3.12 branch) for an example.
My understanding was that the attached diff is an example of a diff cluttered by keyword expansions, not a patch to be applied. The solution would rather be to remove all the lines with SVN keywords from the sources. Stéphane: is it indeed what you mean?
Yes, probably my misunderstanding, as the keywords don't get expanded in git. So, yes, I understood that the patch is just an example, and we should remove all the $Id$ instead, however I observed that they don't get expanded anyway, in my git svn repo, so I just replaced the ones that were comited by incident. I was just about to send the e-mail to the mailing list with the query what shall we do with it, as the keyword expansions is pretty useless now days.
Original bug ID: 5504
Reporter: @glondu
Assigned to: meyer
Status: closed (set by @xavierleroy on 2013-08-31T10:46:38Z)
Resolution: fixed
Priority: normal
Severity: minor
Fixed in version: 3.13.0+dev
Category: ~DO NOT USE (was: OCaml general)
Monitored by: meyer mehdi @damiendoligez
Bug description
They uselessly clutter diffs against release tarballs, making reviewing more difficult for almost no benefit.
They can also lead to errors such as committing unwanted changes. See the attached patch (against 3.12 branch) for an example.
File attachments
The text was updated successfully, but these errors were encountered: