Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider stopping using keyword substitutions #5504

Closed
vicuna opened this issue Feb 10, 2012 · 4 comments
Closed

Please consider stopping using keyword substitutions #5504

vicuna opened this issue Feb 10, 2012 · 4 comments
Labels

Comments

@vicuna
Copy link

vicuna commented Feb 10, 2012

Original bug ID: 5504
Reporter: @glondu
Assigned to: meyer
Status: closed (set by @xavierleroy on 2013-08-31T10:46:38Z)
Resolution: fixed
Priority: normal
Severity: minor
Fixed in version: 3.13.0+dev
Category: ~DO NOT USE (was: OCaml general)
Monitored by: meyer mehdi @damiendoligez

Bug description

They uselessly clutter diffs against release tarballs, making reviewing more difficult for almost no benefit.

They can also lead to errors such as committing unwanted changes. See the attached patch (against 3.12 branch) for an example.

File attachments

@vicuna
Copy link
Author

vicuna commented Feb 19, 2012

Comment author: meyer

Thanks for reporting that. Similar patch applied with SVN r12170.

@vicuna
Copy link
Author

vicuna commented Feb 19, 2012

Comment author: @alainfrisch

My understanding was that the attached diff is an example of a diff cluttered by keyword expansions, not a patch to be applied. The solution would rather be to remove all the lines with SVN keywords from the sources. Stéphane: is it indeed what you mean?

@vicuna
Copy link
Author

vicuna commented Feb 19, 2012

Comment author: meyer

Yes, probably my misunderstanding, as the keywords don't get expanded in git. So, yes, I understood that the patch is just an example, and we should remove all the $Id$ instead, however I observed that they don't get expanded anyway, in my git svn repo, so I just replaced the ones that were comited by incident. I was just about to send the e-mail to the mailing list with the query what shall we do with it, as the keyword expansions is pretty useless now days.

@vicuna
Copy link
Author

vicuna commented Feb 19, 2012

Comment author: @glondu

Stéphane: is it indeed what you mean?

It is indeed.

I observed that they don't get expanded anyway, in my git svn repo

I use git-svn too. But keywords are expanded in the tarballs that are released, and this is what I'm complaining about.

@vicuna vicuna closed this as completed Aug 31, 2013
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant