Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning 31 (linking twice the same module name) cannot be made fatal #5526

Closed
vicuna opened this issue Mar 7, 2012 · 1 comment
Closed
Assignees
Labels

Comments

@vicuna
Copy link

vicuna commented Mar 7, 2012

Original bug ID: 5526
Reporter: @alainfrisch
Assigned to: @alainfrisch
Status: closed (set by @xavierleroy on 2013-08-31T10:48:42Z)
Resolution: fixed
Priority: normal
Severity: minor
Category: ~DO NOT USE (was: OCaml general)

Bug description

The new warning 31 is never turned into an error, even with -warn-error +31.

This is because Warnings.check_fatal is only called after compilation, not linking.

@vicuna
Copy link
Author

vicuna commented Mar 7, 2012

Comment author: @alainfrisch

Commit 12196. I've added calls to check_fatal after all linking operations in main.ml and optmain.ml (even though some of these operations can currently raise warnings, but this could change later).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants