Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Unix.fstat not returning S_SOCK #5581

Closed
vicuna opened this issue Apr 10, 2012 · 3 comments
Closed

Windows: Unix.fstat not returning S_SOCK #5581

vicuna opened this issue Apr 10, 2012 · 3 comments

Comments

@vicuna
Copy link

vicuna commented Apr 10, 2012

Original bug ID: 5581
Reporter: @alainfrisch
Status: closed (set by @xavierleroy on 2015-12-11T18:04:28Z)
Resolution: not a bug
Priority: low
Severity: tweak
Platform: Windows
Category: otherlibs

Bug description

It seems that Window's version of fstat does not return whether the handle is a socket or not; consequently S_SOCK is never returned. But we keep in the filedescr structure this information, and so we would be able to return S_SOCK when appropriate.

@vicuna
Copy link
Author

vicuna commented Apr 10, 2012

Comment author: gerd

Unix only returns S_SOCK when the file is a Unix domain socket (which do not exist in Windows), but not for other kinds of sockets. If we keep this compatibility, the win32 port should behave in the same way, i.e. never return S_SOCK.

@vicuna
Copy link
Author

vicuna commented Apr 10, 2012

Comment author: @damiendoligez

Alain, do you have any answer to Gerd's objection?

@vicuna
Copy link
Author

vicuna commented Apr 10, 2012

Comment author: @alainfrisch

Damien: no objection. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant