You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Original bug ID: 5633 Reporter:@garrigue Assigned to:@garrigue Status: closed (set by @xavierleroy on 2015-12-11T18:07:02Z) Resolution: fixed Priority: normal Severity: minor Version: 4.00.0+dev Fixed in version: 4.00.0+dev Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues Related to:#5442
Bug description
The file is 6000 lines long, but this still seems too much.
I have not yet investigated the cause.
(For all I know, I might even be the cause...)
The text was updated successfully, but these errors were encountered:
A wild guess: this sounds suspiciously like the Camlp4 slowdown which was fixed by commits r12391 (in trunk) and r12415 (in 4.00 branch). However, it seems that Camlp4 was not bootstrapped since then, so maybe the bootstrapped Camlp4 still contains this particular slowdown. Could someone knowledgeable with Camlp4 do a bootstrap cycle and tell us if it makes any difference?
Indeed, the problem seems to disappear with a bootstrap cycle (explained in build/camlp4-bootstrap-recipe.txt).
Note however that the fix to #5442 was fragile: it disappeared with each camlp4 bootstrap!
I fixed that by moving the changes to camlp4/Camlp4Filters/Camlp4MetaGenerator.ml.
As a result, escaping applies not only to Expr but also to the Patt submodule, which was not escaped before.
I don't know whether this is the right behavior (it makes sense at least).
Changes committed in trunk and 4.00 at revisions 12615 and 12617
Original bug ID: 5633
Reporter: @garrigue
Assigned to: @garrigue
Status: closed (set by @xavierleroy on 2015-12-11T18:07:02Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.00.0+dev
Fixed in version: 4.00.0+dev
Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues
Related to: #5442
Bug description
The file is 6000 lines long, but this still seems too much.
I have not yet investigated the cause.
(For all I know, I might even be the cause...)
The text was updated successfully, but these errors were encountered: