New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some tests are failing in 4.00.0+beta2 #5648
Comments
Comment author: meyer Hi, Thanks. I don't have an access to X86_64 right now, could you specify which test has failed in lib-marshal, that would help me at least assess the severity. Wojciech |
Comment author: meyer Can you apply the patch against trunk attached and see if that fixes the problem? |
Comment author: meyer Can't reproduce it on my 64 bit host - without patch |
Comment author: meyer Hmm, looking at my patch now, I feel it's incorrect. The recursive closures will not be marshaled correctly when they are stored in a block, precisely the rest of the block after the closure will not be marshaled. So feel free to try out the patch but I don't think I can apply it. |
Comment author: @glondu I've just noticed that the lib-marshal test uses -custom. Its failure is Debian-specific (we have a special handling to avoid the strippability issue). Sorry for the noise. However, the lib-threads tests fail even with pristine ocaml sources. |
Comment author: @damiendoligez Non-determinism in the thread semantics makes it difficult to produce a reliable test suite for threads. This needs work. |
Comment author: @damiendoligez I'd like to see the files: Could you please upload them here? |
Comment author: @damiendoligez I found and fixed an i18n bug that probably explains your test failures. (commit 12717 in 4.00, patch included here). If you could re-test with this patch, that would be great. |
Comment author: @glondu Indeed, you're right. All the tests pass with the patch. |
Comment author: meyer Closing, reported problem has been solved |
Original bug ID: 5648
Reporter: @glondu
Assigned to: meyer
Status: closed (set by meyer on 2012-09-02T00:32:09Z)
Resolution: fixed
Priority: normal
Severity: minor
Target version: 4.00.1+dev
Category: ~DO NOT USE (was: OCaml general)
Monitored by: mehdi
Bug description
The following tests fail on my machine (amd64, Debian unstable):
File attachments
The text was updated successfully, but these errors were encountered: