Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove camlp4_import.ml #5672

Closed
vicuna opened this issue Jul 6, 2012 · 5 comments
Closed

Remove camlp4_import.ml #5672

vicuna opened this issue Jul 6, 2012 · 5 comments
Milestone

Comments

@vicuna
Copy link

vicuna commented Jul 6, 2012

Original bug ID: 5672
Reporter: @bobzhang
Assigned to: @diml
Status: closed (set by @xavierleroy on 2016-12-07T10:34:22Z)
Resolution: fixed
Priority: normal
Severity: tweak
Target version: 4.03.0+dev / +beta1
Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues
Monitored by: @alainfrisch

Bug description

Previous building process for camlp4 will try to extract some code from parsing/ at compile time and copy them to camlp4_import.ml

Since ocaml4.00. compilerlibs is officially installed. This ugly hack is no longer required. Then camlp4 is simply a normal ocaml library.(To my limited knowledge, there's not any internal compiler support for camlp4)

@vicuna
Copy link
Author

vicuna commented Aug 24, 2012

Comment author: @bobzhang

For your interest, I have made camlp4 a library with success and a number of bug fixes and feature enhancements (still work in progress),
https://bitbucket.org/HongboZhang/camlp4
A immediate benefit is that the building process is blazing fast. bootstrapping only take 1 min, and building camlp4.byte only takes 30s in my machine
-- For comparison, it takes 20 minutes more or less to go through the bootstrapping process, which makes patching non-necessarily tedious

@vicuna
Copy link
Author

vicuna commented Sep 2, 2012

Comment author: meyer

There is a configure option: -no-camlp4.

@vicuna
Copy link
Author

vicuna commented Sep 21, 2012

Comment author: @bobzhang

I mean technically, building camlp4 still depends on ocaml's source tree, but this is not necessary actually

@vicuna
Copy link
Author

vicuna commented Jul 21, 2014

Comment author: @damiendoligez

Now that camlp4 lives on github, this PR should be moved to its BTS.

@vicuna
Copy link
Author

vicuna commented Aug 1, 2014

Comment author: @diml

This has been fixed in the external camlp4.

@vicuna vicuna closed this as completed Dec 7, 2016
@vicuna vicuna added the camlp4 label Mar 14, 2019
@vicuna vicuna added this to the 4.03.0 milestone Mar 14, 2019
@vicuna vicuna assigned ghost Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant