You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Original bug ID: 5682 Reporter:@alainfrisch Assigned to:@lefessan Status: closed (set by @xavierleroy on 2015-12-11T18:07:19Z) Resolution: fixed Priority: normal Severity: minor Target version: 4.00.0+dev Fixed in version: 4.00.0+dev Category: ~DO NOT USE (was: OCaml general)
Bug description
I believe the the final catch-all handler should not call save_cmt when either print_types or dont_write_files is true.
The text was updated successfully, but these errors were encountered:
Have you found a .cmt file generated when it should not be, or are you just reviewing the code ?
Cmt_format.save_cmt checks that
Clflags.binary_annotations is true (ocamldoc should never set that flag to true, and ocamldoc is the only user of Clflags.dont_write_files from the comments in Clflags)
Since the typer is now shipped into compilerlibs, some other people might make a weird usage of Clflags.dont_write_files, so I just added the test in cmt_format, although you would have to be crazy to both activate Clflags.binary_annotations and Clflags.dont_write_files.
Original bug ID: 5682
Reporter: @alainfrisch
Assigned to: @lefessan
Status: closed (set by @xavierleroy on 2015-12-11T18:07:19Z)
Resolution: fixed
Priority: normal
Severity: minor
Target version: 4.00.0+dev
Fixed in version: 4.00.0+dev
Category: ~DO NOT USE (was: OCaml general)
Bug description
I believe the the final catch-all handler should not call save_cmt when either print_types or dont_write_files is true.
The text was updated successfully, but these errors were encountered: