Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no bound checks anymore on some array operations #5742

Closed
vicuna opened this issue Aug 27, 2012 · 1 comment
Closed

no bound checks anymore on some array operations #5742

vicuna opened this issue Aug 27, 2012 · 1 comment
Labels
bug high-priority stdlib

Comments

@vicuna
Copy link

vicuna commented Aug 27, 2012

Original bug ID: 5742
Reporter: @lefessan
Status: closed (set by @xavierleroy on 2015-12-11T18:19:36Z)
Resolution: fixed
Priority: high
Severity: crash
Version: 4.00.0
Fixed in version: 4.00.1+dev
Category: standard library
Monitored by: @gasche @hcarty @dbuenzli @alainfrisch

Bug description

$ ocaml
OCaml version 4.00.0

Array.sub [||] 0 10;;

  • : '_a array =
    [|; ; ; ; ; ; ; ; ;
    |]

probably since commit 11913:

Module Array: faster implementations of "blit", "copy", "sub",
"append" and "concat" (#2395, #2787, #4591)
@vicuna
Copy link
Author

vicuna commented Aug 28, 2012

Comment author: @xavierleroy

Indeed, the bound check in Array.sub fell through the cracks during commit 11913. Reinstated proper bound checks + a test in the testsuite, commits
r12891 (4.00 bugfix branch) and r12892 (trunk).

@vicuna vicuna closed this as completed Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug high-priority stdlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vicuna