Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlbuild spends a lot of time logging #5756

Closed
vicuna opened this issue Sep 4, 2012 · 3 comments
Closed

ocamlbuild spends a lot of time logging #5756

vicuna opened this issue Sep 4, 2012 · 3 comments

Comments

@vicuna
Copy link

vicuna commented Sep 4, 2012

Original bug ID: 5756
Reporter: meyer
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2017-09-24T15:31:49Z)
Resolution: fixed
Priority: high
Severity: tweak
Version: 4.00.0
Target version: later
Fixed in version: 4.03.0+dev / +beta1
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Related to: #4934
Monitored by: @gasche @ygrek @hcarty

Bug description

It was shown by Ygrek in the parent issue that ocamlbuild spends too much time calling dprintf and performing IO. Perhaps we could disable logging in Solver.ml, functorize Solver and provide dummy functions if logging is disabled.

@vicuna
Copy link
Author

vicuna commented Sep 4, 2012

Comment author: @ygrek

AFAIK short of syntax extension the least awful way to do conditional logging is plain old if test - i.e. if loglevel X then dprintf ...

@vicuna
Copy link
Author

vicuna commented Jul 27, 2015

Comment author: @ygrek

#219

@vicuna
Copy link
Author

vicuna commented Feb 9, 2016

Comment author: @gasche

ygrek's PR was merged in trunk (future 4.03). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants