Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pprintast does not print 'private' flag on type declarations #5794

Closed
vicuna opened this issue Oct 17, 2012 · 4 comments
Closed

Pprintast does not print 'private' flag on type declarations #5794

vicuna opened this issue Oct 17, 2012 · 4 comments
Labels

Comments

@vicuna
Copy link

vicuna commented Oct 17, 2012

Original bug ID: 5794
Reporter: @alainfrisch
Assigned to: @bobzhang
Status: closed (set by @xavierleroy on 2015-12-11T18:08:26Z)
Resolution: fixed
Priority: normal
Severity: minor
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @hcarty

Bug description

(Pprintast is used by the cmt2annot tool and now the -dsource option.)

File attachments

@vicuna
Copy link
Author

vicuna commented Oct 17, 2012

Comment author: @bobzhang

plz review the patch

@vicuna
Copy link
Author

vicuna commented Oct 18, 2012

Comment author: @bobzhang

plz don't apply the patch yet, I will have a much nicer patch a few days later

@vicuna
Copy link
Author

vicuna commented Oct 18, 2012

Comment author: @alainfrisch

Hongbo: I think you can directly commit your fixes to Pprintast when you're ready.

@vicuna
Copy link
Author

vicuna commented Oct 31, 2012

Comment author: @bobzhang

Fixed in revision 13054

@vicuna vicuna closed this as completed Dec 11, 2015
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant