Patch to add ARM VFPv2 support #5798
Comments
|
Comment author: meurer Unless I am overlooking something, this will introduce an armhf variant with VFPv2, right? And the only real difference in code generation is the loading of float constants? |
|
Comment author: jeffsco I think you have it right. The change is indeed very small. VFPv2 doesn't support the FCONSTD/FCONSTS instructions. Otherwise it looks just like VFPv3_D16 (with respect to current ARM code generator). The other changes are all just to fit the new fpu variant into the existing code. I don't know about raspberry changes. |
|
Comment author: @avsm I've uploaded an updated version of Jeff's patch that also adds the right flags to the runtime for VFPE2 support. The Raspberry Pi is an ARMv6, and so the default Debian distribution is soft float. There is an alternative recompiled "Raspbian" distribution which is hard float, and this patch prevents ocamlopt from outputting VFPE3/ThumbII instructions and segfaulting there. It now uses VFPE2 and no Thumb. I've tested this on Raspbian/OCaml-4 and it works great. The patch should have no effect on soft float distributions. It's also available as the "4.00.1+raspberrypi" compiler switch if you use OPAM. |
|
Comment author: meurer Ok, looks good, thanks. Patch applied to trunk with revision 13041. |
|
Comment author: @avsm would it be possible to merge this into one of the 4.0x branches? It's needed to generate binary packages for the Raspberry Pi hardfloat distributions. |
|
Comment author: meurer Merged into 4.00 with revision 13125. |
…ffrey Scofield, Anil Madhavapeddy). [PATCH] Detect and support armv6/VFPE2, which is sufficient to get ocamlopt working on the Raspberry Pi hardfloat Debian variant Original patch: Jeffrey Scofield via http://psellos.com/pub/ocamlxarm/ocaml4-vfpv2.diff Fixes from: Anil Madhavapeddy <anil@recoil.org> git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.00@13125 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
Original bug ID: 5798
Reporter: jeffsco
Assigned to: meurer
Status: closed (set by meurer on 2012-12-10T11:35:56Z)
Resolution: fixed
Priority: normal
Severity: feature
Platform: ARM
OS: Various
Version: 4.00.1
Fixed in version: 4.00.2+dev
Category: back end (clambda to assembly)
Monitored by: @avsm
Bug description
For my port of OCaml 4.00.0 to older iOS devices, I added support for VFPv2 (older floating point). I'm attaching a patch that applies cleanly against 4.00.0 and 4.00.1. I tested the 4.00.0 version under iOS and it works great for me. There is also a report from Anil Madhavapeddy that this patch works for Raspberry Pi.
Steps to reproduce
patch -p0 < ocaml4-vfpv2.diff
File attachments
The text was updated successfully, but these errors were encountered: