Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please add location info to record fields and variant constructors #5900

Closed
vicuna opened this issue Jan 22, 2013 · 2 comments
Closed

please add location info to record fields and variant constructors #5900

vicuna opened this issue Jan 22, 2013 · 2 comments

Comments

@vicuna
Copy link

vicuna commented Jan 22, 2013

Original bug ID: 5900
Reporter: Hendrik Tews
Assigned to: @zoggy
Status: assigned (set by Hendrik Tews on 2013-01-22T21:23:31Z)
Resolution: open
Priority: normal
Severity: feature
Version: 4.00.1
Category: ocamldoc

Bug description

Hi,

for more precise error messages, it would be nice to have *_loc fields in Odoc_info.Type.record_field and variant_constructor.

I would further suggest to tell in the compilation instructions for custom generators (in the manual) that "-I +compiler-libs" is needed, when accessing location information. I would actually prefer that Location.t is reexported somewhere, such that "-I +compiler-libs" is not needed.

Bye,

Hendrik

@vicuna
Copy link
Author

vicuna commented Jul 28, 2013

Comment author: @gasche

It looks like the location information would have to be added in the typedtree first, to type_kind in typing/types.ml, as this is where ocamldoc gets its information about record fields.

@github-actions
Copy link

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant