Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up Parsetree: removing prefixes #5913

Closed
vicuna opened this issue Jan 29, 2013 · 1 comment
Closed

Cleaning up Parsetree: removing prefixes #5913

vicuna opened this issue Jan 29, 2013 · 1 comment

Comments

@vicuna
Copy link

vicuna commented Jan 29, 2013

Original bug ID: 5913
Reporter: @alainfrisch
Status: resolved (set by @xavierleroy on 2013-06-17T14:24:13Z)
Resolution: suspended
Priority: normal
Severity: minor
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @gasche @hcarty

Bug description

Now that we have type-based disambiguation of constructors and labels, it is possible to get rid of prefixes in the Parsetree. This would make writing AST transformers (-ppx) a little bit easier. Such changes to the Parsetree are better done before too many people start writing AST transformers...

I attach a patch (against current trunk) which removes prefixes from most sum types in Parsetree. I've had to add only a very small number of type annotations (around 10, I think) to make everything compile (including Camlp4).

I've kept the prefixes on record types for now, since removing them might require more annotations.

File attachments

@vicuna
Copy link
Author

vicuna commented Jun 17, 2013

Comment author: @xavierleroy

Following the discussion on caml-devel, I'm "suspending" this PR, as there was no consensus on this feature and general agreement that at any rate we should wait until type-based disambiguation has been widely used and debugged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant