You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Original bug ID: 5913 Reporter:@alainfrisch Status: resolved (set by @xavierleroy on 2013-06-17T14:24:13Z) Resolution: suspended Priority: normal Severity: minor Category: ~DO NOT USE (was: OCaml general) Monitored by:@gasche@hcarty
Bug description
Now that we have type-based disambiguation of constructors and labels, it is possible to get rid of prefixes in the Parsetree. This would make writing AST transformers (-ppx) a little bit easier. Such changes to the Parsetree are better done before too many people start writing AST transformers...
I attach a patch (against current trunk) which removes prefixes from most sum types in Parsetree. I've had to add only a very small number of type annotations (around 10, I think) to make everything compile (including Camlp4).
I've kept the prefixes on record types for now, since removing them might require more annotations.
Following the discussion on caml-devel, I'm "suspending" this PR, as there was no consensus on this feature and general agreement that at any rate we should wait until type-based disambiguation has been widely used and debugged.
Original bug ID: 5913
Reporter: @alainfrisch
Status: resolved (set by @xavierleroy on 2013-06-17T14:24:13Z)
Resolution: suspended
Priority: normal
Severity: minor
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @gasche @hcarty
Bug description
Now that we have type-based disambiguation of constructors and labels, it is possible to get rid of prefixes in the Parsetree. This would make writing AST transformers (-ppx) a little bit easier. Such changes to the Parsetree are better done before too many people start writing AST transformers...
I attach a patch (against current trunk) which removes prefixes from most sum types in Parsetree. I've had to add only a very small number of type annotations (around 10, I think) to make everything compile (including Camlp4).
I've kept the prefixes on record types for now, since removing them might require more annotations.
File attachments
The text was updated successfully, but these errors were encountered: