Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caml-help.el (emacs caml-mode) fails #5954

Closed
vicuna opened this issue Mar 17, 2013 · 3 comments
Closed

caml-help.el (emacs caml-mode) fails #5954

vicuna opened this issue Mar 17, 2013 · 3 comments
Assignees
Labels

Comments

@vicuna
Copy link

vicuna commented Mar 17, 2013

Original bug ID: 5954
Reporter: zakkak
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2015-12-11T18:18:33Z)
Resolution: fixed
Priority: normal
Severity: minor
Platform: Intel
OS: lubuntu
OS Version: 12.10
Version: 4.00.1
Category: misc

Bug description

I am using the latest emacs release (24.3) and I installed tuareg and
caml through svn, svn://svn.forge.ocamlcore.org/svn/tuareg/trunk and
http://caml.inria.fr/svn/ocaml/trunk/emacs/ respectively.

When starting tuareg-mode it autoloads caml-help resulting in a
failure with the message:
wrong-type-argument listp class

Steps to reproduce

M-x tuareg-mode

Additional information

The following patch fixes it.

--- caml-help.el
+++ new-caml-help.el
@@ -789,7 +789,7 @@ buffer positions."

(defface ocaml-link-face

  • '(((class color) :foreground "Purple"))
  • '((((class color)) (:foreground "Purple")))
    "Face to highlight hyperlinks.")

(defun ocaml-link-activate (section)

@vicuna
Copy link
Author

vicuna commented Mar 17, 2013

Comment author: @gasche

Could you please confirm that this change does not break compatibility when used with older version of Emacs?

@vicuna
Copy link
Author

vicuna commented Mar 17, 2013

Comment author: zakkak

I confirm that the bug also exists in emacs 23.2.1, 23.4 and 24.1. The patch works for these versions too. I am sorry but I cannot test any earlier versions.

The patch can be simplified (less modifications) to

--- caml-help.el
+++ new-caml-help.el
@@ -789,7 +789,7 @@ buffer positions."

(defface ocaml-link-face

  • '(((class color) :foreground "Purple"))
  • '((((class color)) :foreground "Purple"))
    "Face to highlight hyperlinks.")

(defun ocaml-link-activate (section)

@vicuna
Copy link
Author

vicuna commented Mar 17, 2013

Comment author: @gasche

Thank you, I pushed the fix in the SVN trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants