Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect against marshaling 64-bit integers in bytecode #5986

Closed
vicuna opened this issue Apr 15, 2013 · 2 comments
Closed

Protect against marshaling 64-bit integers in bytecode #5986

vicuna opened this issue Apr 15, 2013 · 2 comments
Assignees
@xavierleroy
Labels
bug

Comments

@vicuna
Copy link

vicuna commented Apr 15, 2013

Original bug ID: 5986
Reporter: @alainfrisch
Assigned to: @xavierleroy
Status: closed (set by @xavierleroy on 2015-12-11T18:18:38Z)
Resolution: fixed
Priority: normal
Severity: minor
Category: ~DO NOT USE (was: OCaml general)
Related to: #5977

Bug description

The generic marshaling function should take a flag to forbid it from emitting 64-bit integer (because the resulting value cannot be read from a 32-bit process).

The bytecode compiler should be extended with a command-line flag to prevent it from emitting such integers in structured constants (using the feature above), and we should use this flag when bootstrapping, so that the resulting bytecode executable are usable under 32-bit architectures.
@vicuna
Copy link
Author

vicuna commented Apr 15, 2013

Comment author: @xavierleroy

Working on it.

@vicuna
Copy link
Author

vicuna commented Apr 18, 2013

Comment author: @xavierleroy

Implemented in trunk, r13554: option Marshal.Compat_32 to the Marshal.to_* functions and flag -compat-32 to ocamlc.

@vicuna vicuna closed this as completed Dec 11, 2015
@vicuna vicuna mentioned this issue Dec 11, 2015
Closed
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xavierleroy xavierleroy

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xavierleroy @vicuna