Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught exceptions & packing #5995

Closed
vicuna opened this issue Apr 21, 2013 · 4 comments
Closed

Uncaught exceptions & packing #5995

vicuna opened this issue Apr 21, 2013 · 4 comments
Assignees
@alainfrisch
Labels
bug
Milestone
4.03.0

Comments

@vicuna
Copy link

vicuna commented Apr 21, 2013

Original bug ID: 5995
Reporter: @Chris00
Assigned to: @alainfrisch
Status: closed (set by @xavierleroy on 2017-02-16T14:18:15Z)
Resolution: fixed
Priority: low
Severity: minor
Platform: x86_64
OS: Debian/Linux
OS Version: 3.9.0
Version: 4.00.1
Target version: 4.03.0+dev / +beta1
Fixed in version: 4.03.0+dev / +beta1
Category: ~DO NOT USE (was: OCaml general)
Related to: #6506
Monitored by: @hcarty

Bug description

When packing a module B into a module A, the exceptions, say E, declared in B must be of course accessed as A.B.E. However, when the exception is uncaught, what is printed on screen is B.E instead of A.B.E which may be confusing...
@vicuna
Copy link
Author

vicuna commented Apr 21, 2013

Comment author: @lefessan

I can confirm the issue is present with native code.

The problem is that, since -for-pack is optional with bytecode, fixing this issue would introduce a difference between the execution in bytecode and native code.

Maybe it should be fixed both for bytecode and native code when -for-pack is provided.

@vicuna
Copy link
Author

vicuna commented Feb 24, 2015

Comment author: @damiendoligez

We should definitely fix it for both when -for-pack is provided, then remove the sentence in the documentation that makes -for-pack optional for bytecode.

@vicuna
Copy link
Author

vicuna commented Dec 11, 2015

Comment author: @alainfrisch

Commit a24e4ed: fix the naming of exception when compiling with -for-pack.

@vicuna
Copy link
Author

vicuna commented Dec 11, 2015

Comment author: @alainfrisch

Commit a9854a4: document -for-pack as mandatory for ocamlc.

@vicuna vicuna closed this as completed Feb 16, 2017
@vicuna vicuna added this to the 4.03.0 milestone Mar 14, 2019
@vicuna vicuna mentioned this issue Mar 14, 2019
Closed
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alainfrisch alainfrisch

Labels
bug
Projects
None yet
Milestone
4.03.0
Development

No branches or pull requests
2 participants
@alainfrisch @vicuna