Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Module.(expr)" emitted incorrectly to source #6106

Closed
vicuna opened this issue Jul 30, 2013 · 2 comments
Closed

"Module.(expr)" emitted incorrectly to source #6106

vicuna opened this issue Jul 30, 2013 · 2 comments

Comments

@vicuna
Copy link

vicuna commented Jul 30, 2013

Original bug ID: 6106
Reporter: @mmottl
Status: closed (set by @diml on 2016-12-07T17:27:30Z)
Resolution: open
Priority: normal
Severity: minor
Version: 4.00.1
Target version: later
Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues
Monitored by: @mmottl

Bug description

Consider file foo.ml:

let t = ref 0
let f () = t := Pervasives.(0); t := 42

Using "camlp4o -printer o foo.ml -o bar.ml" we obtain the following in "bar.ml":

let t = ref 0

let f () = (t := let open Pervasives in 0; t := 42)

The above is incorrect: "let open Pervasives in 0" needs to be put in parentheses, otherwise the assigned expression ends in "t := 42", which should be the subsequent assignment.

@vicuna
Copy link
Author

vicuna commented Jul 22, 2014

Comment author: @damiendoligez

Needs to be transferred to the camlp4 BTS.

@vicuna
Copy link
Author

vicuna commented Dec 7, 2016

Comment author: @diml

Camlp4 is now a separate project. Please re-open a ticket on github [1] if you are still interested in seeing the original issue fixed.

[1] https://github.com/ocaml/camlp4/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant