Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure doesn't detect features correctly on Haiku #6207

Closed
vicuna opened this issue Oct 14, 2013 · 5 comments
Closed

Configure doesn't detect features correctly on Haiku #6207

vicuna opened this issue Oct 14, 2013 · 5 comments
Assignees
@damiendoligez
Labels
bug configure-related
Milestone
4.02.1

Comments

@vicuna
Copy link

vicuna commented Oct 14, 2013

Original bug ID: 6207
Reporter: jessicah
Assigned to: @damiendoligez
Status: closed (set by @damiendoligez on 2014-10-03T12:25:45Z)
Resolution: fixed
Priority: normal
Severity: minor
Platform: Haiku
Version: 4.01.0
Target version: 4.02.1+dev
Fixed in version: 4.02.1+dev
Category: configure and build/install
Tags: patch

Bug description

Features such as support for sockets, systhreads, and natdynlink don't get detected correctly on Haiku.

File attachments
@vicuna
Copy link
Author

vicuna commented Oct 15, 2013

Comment author: @gasche

A "detect feature" patch should probably not come with changes to systhreads and unix/nice.c. What are those doing? Could you upload separate patches (possibly on this one bugtracking issue)?

@vicuna
Copy link
Author

vicuna commented Oct 15, 2013

Comment author: jessicah

The change to systhreads is part of the build system (renamed defines produced by configure). Haiku doesn't have nice(). I'll see if I can do that another way, actually.

@vicuna
Copy link
Author

vicuna commented Oct 15, 2013

Comment author: jessicah

FWIW, the check for getpriority/setpriority in configure are never used (although Haiku doesn't yet support these either).

The change to nice.c is due to missing POSIX support in Haiku.

@vicuna
Copy link
Author

vicuna commented Jul 16, 2014

Comment author: @damiendoligez

To whoever applies this patch: please define an explicit HAS_NICE in config/s.h and use that rather than keying on HAIKU in nice.c.

@vicuna
Copy link
Author

vicuna commented Oct 3, 2014

Comment author: @damiendoligez

Patch applied with fixes in branch 4.02 (rev 15444).

@vicuna vicuna closed this as completed Oct 3, 2014
@vicuna vicuna added this to the 4.02.1 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiendoligez damiendoligez

Labels
bug configure-related
Projects
None yet
Milestone
4.02.1
Development

No branches or pull requests
2 participants
@damiendoligez @vicuna