Anonymous | Login | Signup for a new account | 2019-02-20 02:31 CET | ![]() |
Main | My View | View Issues | Change Log | Roadmap |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | Project | Category | View Status | Date Submitted | Last Update | |||
0006316 | OCaml | standard library | public | 2014-02-04 04:12 | 2017-02-16 15:15 | |||
Reporter | seliopou | |||||||
Assigned To | gasche | |||||||
Priority | normal | Severity | minor | Reproducibility | always | |||
Status | closed | Resolution | fixed | |||||
Platform | OCaml 4.01.0 | OS | Debian | OS Version | wheezy/sid | |||
Product Version | 4.01.0 | |||||||
Target Version | 4.03.0+dev / +beta1 | Fixed in Version | 4.03.0+dev / +beta1 | |||||
Summary | 0006316: Scanf cannot parse large unsigned int64s | |||||||
Description | Any string literal representing an unsigned int64 that is larger than 2^63 cannot be parsed by Scanf.sscanf using the format string "%Lu". | |||||||
Steps To Reproduce | The following code snippet consistently reproduces the issue: Scanf.sscanf "12306459064359371967" "%Lu" (fun i -> i);; | |||||||
Tags | junior_job | |||||||
Attached Files | ![]() ![]() | |||||||
![]() |
|
(0013909) doligez (administrator) 2015-05-12 17:36 |
@gasche: shouldn't we postpone this one to 4.03? |
(0013910) gasche (administrator) 2015-05-12 17:42 |
Reasonable. I will postpone it so that it doesn't block the release, but if a patch comes in time, and is safe, I will be tempted to merge it in 4.02. |
(0013912) bvaugon (developer) 2015-05-13 11:44 |
I attatch two patches that fix the problem with two different solutions : * Version 1: OCaml implementation of unsigned_{int,int32,int64,nativeint}_of_string + Pure OCaml (improved portability) + Faster than C implem (surprisingly, or not ^^) - Code replication to manage int, int32, int64 and nativeint - Increase scanf.ml code size * Version 2: extend int_of_string functionnality with "0u1234" syntax (for unsigned ints) + Little code modification + Extend int_of_string functionalities - A bit slower and less readable Any opinion? |
(0013914) gasche (administrator) 2015-05-13 13:37 |
The first patch is too invasive for 4.02, but could be an option for 4.03 (but it's not clear to me why we would write the unsigned parsing functions in OCaml, and keep the signed parsing in C). The second patch seems reasonable, I'd like the opinion of our release manager. |
(0013915) bvaugon (developer) 2015-05-13 14:10 |
In fact, since the OCaml implementation of int_of_string'like functions seems to be (between 1.5 and 2 times) faster than the current C implementation (on some machines, maybe not anywhere), it might be interresting (also for portability, homogeneity and simplicity) to encode all of them in OCaml. The first version principally adds code, and contains modifications of only few lines of the existing ml code. IMHO, it seems safer to release it than the second version that modify the existing C code, except if the syntax "0u..." is considered interesting for int_of_string. I forgot to tell that this patch also fix "%u", "%lu" and "%nu". |
(0014252) xleroy (administrator) 2015-07-24 11:38 |
Fixed in commit 16241. I came up independently with the second approach suggested by bvaugon, so it must be the right approach :-) I didn't feel the need to reject int_of_string "-0u123", because we already have a tolerance for int_of_string "-0x123". |
![]() |
|||
Date Modified | Username | Field | Change |
2014-02-04 04:12 | seliopou | New Issue | |
2014-06-19 17:51 | gasche | Tag Attached: junior_job | |
2014-07-16 10:33 | doligez | Status | new => acknowledged |
2014-07-16 10:33 | doligez | Product Version | => 4.01.0 |
2014-07-16 10:33 | doligez | Target Version | => 4.02.1+dev |
2014-09-04 00:25 | doligez | Target Version | 4.02.1+dev => undecided |
2014-09-15 12:40 | doligez | Target Version | undecided => 4.02.2+dev / +rc1 |
2015-05-06 15:22 | gasche | Assigned To | => gasche |
2015-05-06 15:22 | gasche | Status | acknowledged => assigned |
2015-05-12 17:36 | doligez | Note Added: 0013909 | |
2015-05-12 17:42 | gasche | Note Added: 0013910 | |
2015-05-12 17:42 | gasche | Target Version | 4.02.2+dev / +rc1 => 4.02.3+dev |
2015-05-13 11:43 | bvaugon | File Added: diff-ocaml-4.02.1-fix-unsigned-scanf-v1.patch | |
2015-05-13 11:44 | bvaugon | File Added: diff-ocaml-4.02.1-fix-unsigned-scanf-v2.patch | |
2015-05-13 11:44 | bvaugon | Note Added: 0013912 | |
2015-05-13 13:37 | gasche | Note Added: 0013914 | |
2015-05-13 14:10 | bvaugon | Note Added: 0013915 | |
2015-05-24 16:57 | gasche | Relationship added | related to 0006649 |
2015-07-10 18:53 | doligez | Target Version | 4.02.3+dev => 4.03.0+dev / +beta1 |
2015-07-24 11:38 | xleroy | Note Added: 0014252 | |
2015-07-24 11:38 | xleroy | Status | assigned => resolved |
2015-07-24 11:38 | xleroy | Resolution | open => fixed |
2015-07-24 11:38 | xleroy | Fixed in Version | => 4.03.0+dev / +beta1 |
2015-07-25 09:06 | xleroy | Relationship deleted | related to 0006649 |
2017-02-16 15:15 | xleroy | Status | resolved => closed |
2017-02-23 16:43 | doligez | Category | OCaml standard library => standard library |
Copyright © 2000 - 2011 MantisBT Group |