Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running clang-analyzer on OCaml runtime finds bugs #6430

Closed
vicuna opened this issue May 17, 2014 · 4 comments
Closed

Running clang-analyzer on OCaml runtime finds bugs #6430

vicuna opened this issue May 17, 2014 · 4 comments
Assignees

Comments

@vicuna
Copy link

vicuna commented May 17, 2014

Original bug ID: 6430
Reporter: @whitequark
Assigned to: @lpw25
Status: closed (set by @xavierleroy on 2015-12-11T18:27:05Z)
Resolution: not a bug
Priority: normal
Severity: minor
Category: runtime system and C interface
Monitored by: @diml

Bug description

The results are available here: http://fehu.whitequark.org/files/scan-build-2014-05-18-10/

Preliminary analysis:

Bug:

Possible bug:

Benign:

False positive:

Steps to reproduce

Use the trunk compiler with added Noreturn qualifiers: #64 This reduces false positives.

Install clang-analyzer.

Build it as follows:

scan-build ./configure -cc /usr/share/clang/scan-build/ccc-analyzer
scan-build make clean world world.opt

@vicuna
Copy link
Author

vicuna commented May 17, 2014

Comment author: @whitequark

On a second look, yacc/mkpar.c:238 is a false positive.

@vicuna
Copy link
Author

vicuna commented May 18, 2014

Comment author: @lpw25

I could be wrong but otherlibs/unix/wait.c and yacc/reader.c both look like false positives/benign to me.

@vicuna
Copy link
Author

vicuna commented May 19, 2014

Comment author: @xavierleroy

I, too, found wait.c to be a false alarm. So, in the end, do we have true alarms in there?

@vicuna
Copy link
Author

vicuna commented May 19, 2014

Comment author: @whitequark

I have reviewed all of the cases, including "Possible bug" ones, and now I agree with you. Indeed, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants