Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be documented that Lexer.set_preprocessor receives EOL tokens #6453

Closed
vicuna opened this issue Jun 9, 2014 · 1 comment
Closed

Comments

@vicuna
Copy link

vicuna commented Jun 9, 2014

Original bug ID: 6453
Reporter: furuse
Status: closed (set by @damiendoligez on 2014-07-21T21:06:07Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.02.0+beta1 / +rc1
Target version: 4.02.0+dev
Fixed in version: 4.02.0+dev
Category: documentation

Bug description

I found Lexer.set_preprocessor is added to OCaml 4.02.0 and played with it a bit. It is cool!

One tricky thing I have experienced that preprocessors receive lexer token streams a bit different from the original. They contain EOL. The code is in the token rule and it was hard to find out first for me.

This must be documented at the comment of the function in lexer.mli

@vicuna
Copy link
Author

vicuna commented Jul 21, 2014

Comment author: @damiendoligez

Added the information to lexer.mli in 4.02 (commit 15019).

@vicuna vicuna closed this as completed Jul 21, 2014
@vicuna vicuna added this to the 4.02.0 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant