Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Dependency problem to CamlinternalFormat in StdlibModules #6459

Closed
vicuna opened this issue Jun 16, 2014 · 3 comments
Closed

[patch] Dependency problem to CamlinternalFormat in StdlibModules #6459

vicuna opened this issue Jun 16, 2014 · 3 comments
Assignees

Comments

@vicuna
Copy link

vicuna commented Jun 16, 2014

Original bug ID: 6459
Reporter: bvaugon
Assigned to: @garrigue
Status: closed (set by @garrigue on 2014-06-17T09:38:53Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.02.0+beta1 / +rc1
Fixed in version: 4.02.0+dev
Category: standard library

Bug description

In the OCaml toplevel:

CamlinternalFormat.make_printf;;

Error: Reference to undefined global `CamlinternalFormat'

Fixed by the attached patch.

File attachments

@vicuna
Copy link
Author

vicuna commented Jun 17, 2014

Comment author: @garrigue

Shouldn't we also include CamlinternalFormatBasics ?
Or do you think there is no need to access its functions ?
(concat_fmt is re-exported by Pervasives, but not
concat_fmtty and erase_rel.)

@vicuna
Copy link
Author

vicuna commented Jun 17, 2014

Comment author: bvaugon

That's right, it is probably better to also include CamlinternalFormatBasics. Furthermore, since the others CamlinternalXXX are included, it might be considered as more uniform to include all of them.

@vicuna
Copy link
Author

vicuna commented Jun 17, 2014

Comment author: @garrigue

Fixed in 4.02 at revision 14987.
Added both camlinternalFormat and camlinternalFormatBasics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants