New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recursive modules do not correctly handle class inheritance #6491
Comments
This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc. |
|
I think this would fix the issue and probably break no programs in practice. Should I make a quick PR to do this? or do you think there will be some issue with this approach. |
You mean, having an error rather than inferring a wrong type? |
This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc. |
This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc. |
Prohibit using classes through recursive modules (fixes #6491)
Original bug ID: 6491
Reporter: @lpw25
Status: acknowledged (set by @damiendoligez on 2014-07-30T20:39:30Z)
Resolution: open
Priority: normal
Severity: feature
Target version: later
Category: typing
Tags: recmod
Monitored by: @gasche
Bug description
Recursive modules can contain classes or class types which inherit from each other. However, since inheritance is done by copying the methods and values, the information only passes through one layer of inheritance. For example the
x
method is missing fromBaz.c
in the following:Module types would suffer from the same problem, but instead it gives an error:
The same could be achieved for inheritance by calling
find_class_type
on any inherited class types duringapprox_class
.The text was updated successfully, but these errors were encountered: