New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsetree.row_field.Rtag should have constructor location #6499
Comments
Comment author: @damiendoligez It's a good idea to file a report here. TODO in source file is largely ignored, PRs here have more visibility. |
Comment author: @diml I second this request, not having a location here is annoying. Although it seems to me that [Rinherit _] should have a location as well, for consistency. Maybe we should split the [row_field] type between a wrapper record and a [row_field_desc] type as it is done for the other nodes? |
Comment author: @whitequark
I agree that this makes sense. |
This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc. |
Still an issue. |
This was fixed by #1903 as far as I can see. |
Ah, I missed that! Thanks. |
Original bug ID: 6499
Reporter: @whitequark
Assigned to: @diml
Status: assigned (set by @whitequark on 2017-01-06T21:26:21Z)
Resolution: open
Priority: normal
Severity: feature
Version: 4.02.0+beta1 / +rc1
Category: lexing and parsing
Bug description
There's a TODO in parsetree.mli about that, but I'll file a bug for posterity anyway, since this is quite annoying.
The text was updated successfully, but these errors were encountered: