You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After a deeper look, the testcase is faulty here: it assumes the caml_*string_getN primitives are portable. Looking at their C implementation, they are not.
Original bug ID: 6630
Reporter: @glondu
Assigned to: @mshinwell
Status: closed (set by @xavierleroy on 2016-12-07T10:49:23Z)
Resolution: fixed
Priority: normal
Severity: major
Version: 4.02.1
Target version: 4.02.2+dev / +rc1
Fixed in version: 4.02.2+dev / +rc1
Category: ~DO NOT USE (was: OCaml general)
Tags: patch
Monitored by: @gasche @yallop
Bug description
The aforementioned tests fail (at least) on powerpc and s390x (which are big-endian). The diff makes me think about an endianness issue.
Additional information
$ wdiff testsuite/tests/prim-bigstring/string_access.{reference,result}
1234 [-12-] {+3400+} 0
fedc [-fe-] {+dc00+} 0
12345678 [-123456 1234-] {+34567800 56780000+}
fedcba09 [-fedcba fedc-] {+dcba0900 ba090000+}
1234567890abcdef [-1234567890abcd 1234567890ab-] {+34567890abcdef00 567890abcdef0000+}
fedcba0987654321 [-fedcba09876543 fedcba098765-] {+dcba098765432100 ba09876543210000+}
$ wdiff testsuite/tests/prim-bigstring/bigstring_access.{reference,result}
1234 [-12-] {+3400+} 0
fedc [-fe-] {+dc00+} 0
12345678 [-123456 1234-] {+34567800 56780000+}
fedcba09 [-fedcba fedc-] {+dcba0900 ba090000+}
1234567890abcdef [-1234567890abcd 1234567890ab-] {+34567890abcdef00 567890abcdef0000+}
fedcba0987654321 [-fedcba09876543 fedcba098765-] {+dcba098765432100 ba09876543210000+}
File attachments
The text was updated successfully, but these errors were encountered: