Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0006697OCamllexing and parsingpublic2014-12-08 10:532017-10-11 12:41
Reporterwhitequark 
Assigned To 
PrioritynormalSeverityfeatureReproducibilityalways
StatusacknowledgedResolutionopen 
PlatformOSOS Version
Product Version 
Target Version4.07.0+devFixed in Version 
Summary0006697: Turn warning on using non-US-ASCII ISO-8859-1 characters in identifiers into error
DescriptionAs discussed in 0006695, OCaml is currently unable to turn those into proper filenames anyway.
Tagspatch
Attached Filespatch file icon latin1.patch [^] (6,850 bytes) 2014-12-19 06:03 [Show Content]

- Relationships
related to 0006695closedwhitequark Do not treat paths as encoded in ISO-8859-1 
related to 0006692closed Identifiers in Unicode 

-  Notes
(0012883)
whitequark (developer)
2014-12-19 06:03

Reminder sent to: gasche

@gasche, please take a look at the attached patch.

The patch simply removes the lexing rules corresponding to Latin-1 in identifiers, which will fall back to the rule handling all other invalid characters.
(0012895)
gasche (developer)
2014-12-19 18:27

I think the patch is correct and would be in favor of merging, but I'll wait for a second positive opinion on this.
(0013087)
doligez (administrator)
2015-01-13 22:59

0006695 is not relevant for this: we have some users who use latin-1 characters in their variable names, and the warning was introduced relatively recently. Is it already time to turn it into an error? What's the hurry anyway?
(0013088)
whitequark (developer)
2015-01-13 23:04
edited on: 2016-04-18 15:04

I've linked 0006695 as a part of a bigger effort to remove latin1-specific code.


- Issue History
Date Modified Username Field Change
2014-12-08 10:53 whitequark New Issue
2014-12-08 10:54 whitequark Relationship added related to 0006695
2014-12-08 11:09 frisch Relationship added related to 0006692
2014-12-09 23:01 doligez Description Updated View Revisions
2014-12-19 05:58 whitequark File Added: latin1.patch
2014-12-19 06:03 whitequark Note Added: 0012883
2014-12-19 06:03 whitequark File Deleted: latin1.patch
2014-12-19 06:03 whitequark File Added: latin1.patch
2014-12-19 18:23 gasche Status new => acknowledged
2014-12-19 18:27 gasche Note Added: 0012895
2015-01-13 22:57 doligez Tag Attached: patch
2015-01-13 22:59 doligez Note Added: 0013087
2015-01-13 22:59 doligez Target Version => 4.03.0+dev / +beta1
2015-01-13 23:04 whitequark Note Added: 0013088
2016-04-18 15:04 doligez Note Edited: 0013088 View Revisions
2016-04-18 15:04 doligez Target Version 4.03.0+dev / +beta1 => 4.03.1+dev
2017-02-16 14:01 doligez Target Version 4.03.1+dev => undecided
2017-02-23 16:36 doligez Category OCaml general => -OCaml general
2017-02-24 13:30 doligez Category -OCaml general => lexing and parsing
2017-02-24 13:30 doligez Target Version undecided => 4.06.0 +dev/beta1/beta2/rc1
2017-03-07 15:56 shinwell Severity minor => feature
2017-10-11 12:41 frisch Target Version 4.06.0 +dev/beta1/beta2/rc1 => 4.07.0+dev


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker