New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
topdirs.cmi multiple locations #6754
Comments
Comment author: @whitequark Special-casing the md5 in ocamlfind is of course not the answer. It's not even stable between builds of ocaml. Why can't topdirs.cmi be installed only in lib/ocaml, anyway? |
Comment author: @ygrek I mean that once ocamlfind detects same cmi occuring in multiple dirs it could check the md5 of those cmi and if they all are equal - it means interfaces are really equal. |
Comment author: @damiendoligez Interesting. My first reaction was put it into lib/ocaml/compiler-libs, where you also find toploop, topmain, and topstart. @whitequark, do you have any particular reason to want it in lib/ocaml ? |
Comment author: @whitequark I thought topfind uses Topdirs but I now see that it does #directory "+compiler-libs" so that doesn't matter anyway. |
Comment author: @hcarty Is it safe to move/remove lib/ocaml/topdirs.cmi? Anything using ppx_blob, for example, generates lots of findlib warnings. Moving that file and adding '#directory "+compiler-libs";;' to my ~/.ocamlinit allowed utop to work and code to compile without the findlib warnings. |
Comment author: @whitequark @doligez, right, hcarty's comment above is why I wanted it in lib/ocaml, I think |
Comment author: @hhugo Any chance to see this resolved for 4.03 ? |
Comment author: @johnwhitington This warning is, by default, fatal to ocamlmktop, so one has to do "-warn-error -31" if making a custom top level with compiler-libs. Does anyone know why warning 31 should be fatal for ocamlmktop but not ocamlc? |
Comment author: pveber Removing lib/ocaml/topdirs.cmi seems the cleanest solution to me. For the record, this would require some adjustments in opam (for the generated .ocamlinit) and oasis (the generated setup.ml file in dynamic update mode) and maybe other libs. Before doing anything, it would wiser I think to announce/discuss it on the list, so that everybody can think and report on the possible implications. In any case, it would be great to fix this. I can provide some help if needed. |
Comment author: @gasche We missed the timeline for 4.03 on this one. If someone (Philippe included) is willing to take action on this issue (starting a mailing-list discussion etc.), now would be an excellent time, so that we get a change early in the 4.04+dev lifetime. |
Likely related bug#1156934 ocaml-runtime requires ocaml-compiler-libs-devel |
Anyone knows what is the status of this? It appears it is still the case that |
I think that the two copies were left around for compatibility (originally it was just in |
Thanks; an even better solutions would be provided by #9056 as we can make just the one file visible to the compiler, see #5628. |
This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc. |
This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc. |
I think this was fixed by #11199. |
Original bug ID: 6754
Reporter: @ygrek
Status: acknowledged (set by @damiendoligez on 2015-02-06T17:43:54Z)
Resolution: open
Priority: normal
Severity: minor
Version: 4.02.1
Target version: 4.07.0+dev/beta2/rc1/rc2
Category: standard library
Monitored by: kandu @hhugo @whitequark @gasche @rixed @yallop @hcarty @mmottl
Bug description
and every invocation of compiler referencing compiler-libs results in ocamlfind warning
The md5 sum of both modules is the same. I wonder what would be the best way to remove this warning - either the OCaml distribution should install it only in one place or ocamlfind should check md5 and not report it as duplicate because whichever is used will not matter?
The text was updated successfully, but these errors were encountered: