You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
6794 added support for passing -package and -thread options to ocamlfind for C files.
oasis automatically adds "-thread" for ocaml files when they are flagged with "package(threads)". But it does it only for ocaml files and still flags C files with "package(X)" for every package, even though this is useless at the moment.
I guess this is more an oasis bug, but it will affect packages with C stubs using oasis and depending on threads. So it might be safer to revert 6794 from 4.02.2.
I'm marking this "fixed": the oasis-breaking change is removed from the stable 4.02 branch, but still present in trunk. Thanks to Jérémie, oasis should work with trunk by the time of the 4.03 release.
Original bug ID: 6809
Reporter: @chambart
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2017-02-16T14:15:09Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.03.0+dev / +beta1
Target version: 4.03.0+dev / +beta1
Fixed in version: 4.02.2+dev / +rc1
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Related to: #6794
Bug description
When building core 112.17.00:
with ocamlbuild from OCaml 4.02.1:
$ ocamlbuild -use-ocamlfind -classic-display lib/bigstring_stubs.o
/home/chambart/.opam/4.02.1/bin/ocamlfind ocamlc -I lib -package core_kernel -c lib/bigstring_stubs.c
with ocamlbuild from trunk:
$ ocamlbuild -use-ocamlfind -classic-display lib/bigstring_stubs.o
/home/chambart/.opam/4.03.0+trunk/bin/ocamlfind ocamlc -I lib -package core_kernel -package variantslib.syntax -package variantslib -package unix -package typerep_lib.syntax -package typerep_lib -package threads -package sexplib_unix -package sexplib.syntax -package sexplib -package pa_test.syntax -package pa_test -package pa_pipebang -package pa_ounit.syntax -package pa_ounit -package pa_bench.syntax -package pa_bench -package herelib.syntax -package herelib -package fieldslib.syntax -package fieldslib -package enumerate.syntax -package custom_printf.syntax -package custom_printf -package core_kernel -package comparelib.syntax -package bin_prot.syntax -package bin_prot -package bigarray -c -o lib/bigstring_stubs.o lib/bigstring_stubs.c
ocamlfind: Error from package `threads': Missing -thread or -vmthread switch
The text was updated successfully, but these errors were encountered: