Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis checklist for due process: testsuite/ and Changes change #7052

Closed
vicuna opened this issue Nov 19, 2015 · 1 comment
Closed

Travis checklist for due process: testsuite/ and Changes change #7052

vicuna opened this issue Nov 19, 2015 · 1 comment
Assignees

Comments

@vicuna
Copy link

vicuna commented Nov 19, 2015

Original bug ID: 7052
Reporter: @gasche
Assigned to: @gasche
Status: resolved (set by @gasche on 2016-12-09T11:53:41Z)
Resolution: fixed
Priority: low
Severity: feature
Category: misc
Monitored by: @diml

Bug description

I would like to have Travis check not only that the testsuite still passes after each pull request (obviously that should be a necessary condition to merge the patch), but also that some "development process things not to forget" have been done, as a kind of optional checklist. I have two checks to propose for now:

  • that the Changes file is modified by the pull request
  • that a file in testsuite/ is modified by the pull request

These tests are of course not mandatory for all pull-requests (typo-fixing GPRs may pass neither), but having them there would help making sure that we don't forget it.

Additional information

What I need is someone that with some experience buildin custom Travis checks to write these. Please feel free to volunteer!

@vicuna
Copy link
Author

vicuna commented Dec 9, 2016

Comment author: @gasche

The checks are now implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants