Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cross-compilation] Use -I otherlibs/$(UNIXLIB) when building systhreads #7122

Closed
vicuna opened this issue Jan 11, 2016 · 1 comment
Closed

Comments

@vicuna
Copy link

vicuna commented Jan 11, 2016

Original bug ID: 7122
Reporter: adrien
Status: acknowledged (set by @damiendoligez on 2016-02-08T11:39:07Z)
Resolution: open
Priority: normal
Severity: minor
Category: configure and build/install
Tags: cross-compilation, patch

Bug description

Together with #7121, this is basically the last patches that I've needed in order to get a cross-compiler to Windows when updating to trunk (my non-trivial GUI + threads program works, meaning enough is supported; not everything is however).

This one is very simple: in otherlibs/systhreads/Makefile, there is a couple of -I that hardcode their path to $(ROOTDIR)/otherlibs/unix and this simply changes the paths to $(ROOTDIR)/otherlibs/$(UNIXLIB) (i.e. either "unix" or "win32unix").

Thinking more about it, it might read better to replace the use of "$(UNIXLIB)" with "$(IS_WIN32)unix" where IS_WIN32 is either "win32" or "". That's something that would be done later on however.

File attachments

@xavierleroy
Copy link
Contributor

The proposed change seems to have been performed already as part of the great unification between Makefile and Makefile.nt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants