Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations for cross-platform development #7143

Closed
vicuna opened this issue Feb 10, 2016 · 5 comments
Closed

Annotations for cross-platform development #7143

vicuna opened this issue Feb 10, 2016 · 5 comments

Comments

@vicuna
Copy link

vicuna commented Feb 10, 2016

Original bug ID: 7143
Reporter: @damiendoligez
Status: acknowledged (set by @shindere on 2017-02-24T15:48:32Z)
Resolution: open
Priority: normal
Severity: feature
Version: 4.03.0+dev / +beta1
Category: platform support (windows, cross-compilation, etc)
Monitored by: @diml @jmeber @hcarty

Bug description

In #5253#c15148, Christophe Troestler wrote:

With the advent of ppx however, I was wondering if, in addition to the documentation, it would not be desirable to introduce a new attribute to say that some function is only on some os_type. An associated warning (turned off by default) would make possible to be sure that a given code does not use functions specific to a given platform (that would also be useful for some external libraries I think).

I think this is a good idea, so I want it to have its own PR, lest it be forgotten.

@github-actions
Copy link

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

@github-actions github-actions bot added the Stale label Mar 24, 2021
@shindere
Copy link
Contributor

shindere commented Mar 24, 2021 via email

@github-actions github-actions bot removed the Stale label Mar 26, 2021
@damiendoligez
Copy link
Member

It does look like a good idea, though. But I would invert the logic: annotate functions that are missing on a given platform.

@alainfrisch
Copy link
Contributor

And use alerts, I guess.

@github-actions
Copy link

github-actions bot commented May 2, 2022

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

@github-actions github-actions bot added the Stale label May 2, 2022
@github-actions github-actions bot closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants