Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testsuite running on Windows should verify line-endings of source files are correct #7399

Closed
vicuna opened this issue Nov 4, 2016 · 1 comment
Closed

Testsuite running on Windows should verify line-endings of source files are correct #7399

vicuna opened this issue Nov 4, 2016 · 1 comment
Assignees
@dra27
Labels
bug platform-support

Comments

@vicuna
Copy link

vicuna commented Nov 4, 2016

Original bug ID: 7399
Reporter: @dra27
Assigned to: @dra27
Status: resolved (set by @xavierleroy on 2017-10-19T13:31:46Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Target version: later
Fixed in version: 4.06.0 +dev/beta1/beta2/rc1
Category: platform support (windows, cross-compilation, etc)

Bug description

Various tests in the testsuite when run on Windows must use Unix line-endings for certain input and reference files. In certain situations, a git clone working tree can end up with files with the wrong line endings and tests fail.

Additional information

Best fix is probably a Windows-only shell script "parsing" .gitattributes and checking the results (using file, dos2unix, etc.)
@vicuna
Copy link
Author

vicuna commented Oct 19, 2017

Comment author: @xavierleroy

Seems addressed by pull request #1380 which was merged in 4.06.

@vicuna vicuna closed this as completed Oct 19, 2017
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dra27 dra27

Labels
bug platform-support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dra27 @vicuna