Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix.single_write_substring is only available since OCaml 4.02 #7412

Closed
vicuna opened this issue Nov 13, 2016 · 4 comments
Closed

Unix.single_write_substring is only available since OCaml 4.02 #7412

vicuna opened this issue Nov 13, 2016 · 4 comments
Assignees

Comments

@vicuna
Copy link

vicuna commented Nov 13, 2016

Original bug ID: 7412
Reporter: @edwintorok
Assigned to: @Octachron
Status: resolved (set by @Octachron on 2017-02-23T23:44:05Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.02.0
Category: documentation
Monitored by: @gasche

Bug description

The documentation for Unix.single_write_substring doesn't have a since 4.02 annotation: https://caml.inria.fr/pub/docs/manual-ocaml/libref/Unix.html
OTOH Buffer.add_subbytes has the correct annotation

Steps to reproduce

View https://caml.inria.fr/pub/docs/manual-ocaml/libref/Unix.html

Additional information

While viewing dbuenzli/jsonm@ba629f7#diff-48d1573a3f8c418ee1ac7b85e6a0ac30L46 I thought that Unix.single_write_substring could be used instead of the Bytes.unsafe_to_string conversion, however since that library targets 4.01 that function is not available.

@vicuna
Copy link
Author

vicuna commented Nov 13, 2016

Comment author: @gasche

Would you be willing to send a pull-request to add this annotation?

@vicuna
Copy link
Author

vicuna commented Nov 13, 2016

Comment author: @edwintorok

Yeah, I found a few more functions in Unix that lack such annotations, will prepare a PR tomorrow.

@vicuna
Copy link
Author

vicuna commented Nov 15, 2016

Comment author: @alainfrisch

#916

@vicuna vicuna closed this as completed Feb 23, 2017
@vicuna
Copy link
Author

vicuna commented Feb 23, 2017

Comment author: @Octachron

Resolved by merging the github PR linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants