Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of the _WIN32_WINNT macro, minimal version of Windows supported by OCaml #7418

Open
vicuna opened this issue Nov 21, 2016 · 4 comments
Open

Use of the _WIN32_WINNT macro, minimal version of Windows supported by OCaml #7418

vicuna opened this issue Nov 21, 2016 · 4 comments
Labels
bug platform-support windows

Comments

@vicuna
Copy link

vicuna commented Nov 21, 2016

Original bug ID: 7418
Reporter: @shindere
Status: acknowledged (set by @xavierleroy on 2017-02-20T12:46:03Z)
Resolution: open
Priority: normal
Severity: tweak
Version: later
Target version: later
Category: platform support (windows, cross-compilation, etc)
Monitored by: @dra27

Bug description

As discussed on #924(#924),
the macro _WIN32_WINNT whose value defines the minimal version of
Windows required to run a specific piece of code is defined
several times in OCaml sources, with different values.

It seems suitable to figure out whether this is the right thing to do, or whether it wouln't be better to define one value for this macro that would be satisfactory for the whole OCaml source code.
@nojb nojb added the windows label Mar 15, 2019
@vicuna vicuna added the bug label Mar 20, 2019
@github-actions
Copy link

github-actions bot commented May 9, 2020

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

@github-actions github-actions bot added the Stale label May 9, 2020
@dra27 dra27 removed the Stale label May 9, 2020
@github-actions
Copy link

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

@github-actions github-actions bot added the Stale label May 12, 2021
@dra27 dra27 removed the Stale label Jun 16, 2021
@dra27 dra27 reopened this Jun 16, 2021
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

@github-actions github-actions bot added the Stale label Jul 1, 2022
@github-actions github-actions bot closed this as completed Aug 1, 2022
@dra27 dra27 reopened this Aug 3, 2022
@dra27 dra27 removed the Stale label Aug 3, 2022
@dra27
Copy link
Member

dra27 commented Aug 3, 2022

Some work started on this in #11369 - I'm expecting resurrecting the MSVC port in 5.x will be a good opportunity to wind the rest of the codebase forwards (and Microsoft's EOL for pretty much all the older releases are rapidly approaching!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug platform-support windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nojb @dra27 @vicuna