Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a couple of Pprintast issues #7466

Closed
vicuna opened this issue Jan 25, 2017 · 2 comments
Closed

a couple of Pprintast issues #7466

vicuna opened this issue Jan 25, 2017 · 2 comments
Labels
bug newcomer-job

Comments

@vicuna
Copy link

vicuna commented Jan 25, 2017

Original bug ID: 7466
Reporter: @oandrieu
Assigned to: @diml
Status: resolved (set by @diml on 2017-02-01T12:22:29Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.04.0
Fixed in version: 4.04.1+dev
Category: ~DO NOT USE (was: OCaml general)
Tags: junior_job

Bug description

I encountered a couple of AST fragments that are mis-printed by Pprintast:

  • Pexp_setfield
  • prefix operator applications

Steps to reproduce

add at the end of testsuite/tests/parsetree/source.ml :

let f x =
x.contents <- (print_string "coucou" ; x.contents)

let ( ~$ ) x = Some x
let g x =
~$ (x.contents)
@vicuna
Copy link
Author

vicuna commented Jan 25, 2017

Comment author: @gasche

I could reproduce both these bugs on the current trunk.

(An easy way to test pretty-printing from a trunk checkout is to run

TOPFLAGS=-dsource make runtop
)

@vicuna
Copy link
Author

vicuna commented Feb 1, 2017

Comment author: @diml

Fix in 4.04 (0193d73) and trunk (f936036)

@vicuna vicuna closed this as completed Feb 1, 2017
@vicuna vicuna assigned ghost Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug newcomer-job
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vicuna