caml_expand_command_line behaves incorrectly #7473
Comments
|
Comment author: @protz For the record, I'm trying to add a new option to my tool of the form: krml -drop Hacl.Spec.* and I'm just trying to find a way to pass the argument "as-is" without anyone trying to be smart about shell-expansion... if there's a way to bypass caml_expand_command_line I'd be very happy about it. perhaps we should just drop caml_expand_command_line altogether... it seems like a surprising behavior |
|
Comment author: @xavierleroy We have two issues / questions here. 1- Globbing of file name patterns not working. Looks bad indeed, and I'm too lazy to get access to a Windows machine right now. What happens if you put a directory name? As in ".\camlprog.exe ./Hack.Spec.*" 2- Turning globbing off. Currently there is no way to do that. 2a- Why globbing, you ask? I believe(d) this is the behavior of a great many Windows command-line tools, including the MSVC compiler, and Cygwin commands when started from a bash shell. But maybe things have changed in the last 20 years... 2b- Should we give a way to turn globbing off? Perhaps. A flag in OCAMLRUNPARAM would do, for example, but is not terribly friendly. |
|
Comment author: @protz Note: I managed to reproduce on 4.03.0 and 4.04.0 versions, that I built myself. 1- Your suggestion performs proper path expansion. 2a- Granted; I just always start my commands from a cygwin shell so I always relied on bash's shell expansion feature, and never felt the need to have OCaml do it. 2b- unclear... perhaps I'm the only one who wants that sort of options? Hacl.Spec.* denotes the set of F* modules that start with that given prefix... |
|
Comment author: @xavierleroy Thanks for the additional test and info. I strongly suspect bad string surgery on lines 367-370 of byterun/win32.c. |
|
Comment author: @protz Some more info from Redmond. I asked an expert, and:
|
|
Comment author: @xavierleroy So, just by linking with a Microsoft-provided library, all the bugs become theirs? Great! thanks for the tip! Just need to check that setargv.obj is available in Mingw as well as in MSVC... |
|
Comment author: @protz Submitted a pull request for a quickfix that seems to work for me. Otherwise, yes, the more future-proof version is to use the .obj provided by MSVC... but this may prevent David Allsopp from building with circa 1997 versions of MSVC. Feel free to discard the pull request if you want to go with the cleaner version, it didn't take me too long to fix :) |
|
Comment author: @dra27 @protz the globbing expansion via setargv.obj in MSVCRT is as old the hills, you will not break my museum :p @xLeroy - your memory of Cygwin is correct, unless noglob is set in CYGWIN, it does a lot more work to expand wildcards when a Cygwin program is invoked from outside Cygwin (i.e. from cmd) and it's always and continues to be the case that Windows processes are expected to do globbing, not the shell. It would be good if there were a way to prevent the expansion being done (or opt into it?) - we could do that in the same way as Microsoft by adding some kind of setenv.cmo/setenv.cmx or we could consider something less inelegant (like providing the original argv somewhere!)... |
|
Comment author: @xavierleroy Fixed on trunk by merge of commit [561b846]. |
Original bug ID: 7473
Reporter: @protz
Status: resolved (set by @xavierleroy on 2017-02-06T18:58:31Z)
Resolution: fixed
Priority: normal
Severity: major
Version: 4.04.0
Target version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Fixed in version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Category: platform support (windows, cross-compilation, etc)
Bug description
Consider this:
This is the native windows toolchain, compiled with x86_64-w64-mingw32.
This is the contents of the directory:
D:\cygwin\home\protz\Code\hacl-star\code\curve25519>dir Volume in drive D is DATADRIVE1 Volume Serial Number is BA7C-B54F Directory of D:\cygwin\home\protz\Code\hacl-star\code\curve25519 01/31/2017 09:24 AM . 01/31/2017 09:24 AM .. 01/31/2017 09:24 AM 6,697 .vimsession 01/31/2017 09:24 AM 142,833 a.exe 01/31/2017 09:16 AM 634,551 camlprog.exe 01/31/2017 08:35 AM 581 Curve25519.fst 01/31/2017 08:54 AM 26 FStar.c 01/31/2017 08:54 AM 1,057 FStar.h 01/30/2017 03:25 PM 431 Hacl.Bignum.Constants.fst 01/30/2017 03:25 PM 755 Hacl.Bignum.Constants.fst.hints 01/30/2017 03:25 PM 12,781 Hacl.Bignum.Crecip.fst 01/30/2017 03:25 PM 72,855 Hacl.Bignum.Crecip.fst.hints 01/30/2017 03:25 PM 5,860 Hacl.Bignum.Fsquare.fst 01/30/2017 03:25 PM 25,175 Hacl.Bignum.Fsquare.fst.hints 01/30/2017 03:25 PM 3,850 Hacl.Bignum.Modulo.fst 01/30/2017 03:25 PM 29,194 Hacl.Bignum.Modulo.fst.hints 01/30/2017 03:25 PM 10,024 Hacl.Bignum.Parameters.fst 01/30/2017 03:25 PM 61,043 Hacl.Bignum.Parameters.fst.hints 01/30/2017 04:03 PM 28,499 Hacl.EC.AddAndDouble.fst 01/30/2017 03:25 PM 38,849 Hacl.EC.AddAndDouble.fst.hints 01/30/2017 03:47 PM 9,843 Hacl.EC.Format.fst 01/30/2017 03:25 PM 57,407 Hacl.EC.Format.fst.hints 01/31/2017 08:37 AM 3,378 Hacl.EC.fst 01/30/2017 03:25 PM 19,832 Hacl.EC.fst.hints 01/30/2017 03:47 PM 1,139 Hacl.EC.Ladder.BigLoop.fst 01/30/2017 03:25 PM 6,384 Hacl.EC.Ladder.BigLoop.fst.hints 01/30/2017 03:47 PM 5,071 Hacl.EC.Ladder.fst 01/30/2017 03:25 PM 35,464 Hacl.EC.Ladder.fst.hints 01/30/2017 03:25 PM 6,820 Hacl.EC.Ladder.SmallLoop.fst 01/30/2017 03:25 PM 24,478 Hacl.EC.Ladder.SmallLoop.fst.hints 01/30/2017 03:25 PM 6,970 Hacl.EC.Point.fst 01/30/2017 03:25 PM 37,136 Hacl.EC.Point.fst.hints 01/30/2017 03:25 PM 2,482 Hacl.Spec.Bignum.Crecip.fst 01/30/2017 03:25 PM 12,340 Hacl.Spec.Bignum.Crecip.fst.hints 01/30/2017 03:25 PM 787 Hacl.Spec.Bignum.Fmul.Lemmas.fst 01/30/2017 03:25 PM 39,477 Hacl.Spec.Bignum.Fsquare.fst 01/30/2017 03:25 PM 127,079 Hacl.Spec.Bignum.Fsquare.fst.hints 01/30/2017 03:25 PM 11,630 Hacl.Spec.Bignum.Modulo.fst 01/30/2017 03:25 PM 78,665 Hacl.Spec.Bignum.Modulo.fst.hints 01/30/2017 03:25 PM 43,828 Hacl.Spec.EC.AddAndDouble.fst 01/30/2017 03:25 PM 231,152 Hacl.Spec.EC.AddAndDouble.fst.hints 01/30/2017 03:25 PM 5,088 Hacl.Spec.EC.AddAndDouble2.fst 01/30/2017 03:25 PM 13,539 Hacl.Spec.EC.AddAndDouble2.fst.hints 01/30/2017 03:47 PM 7,025 Hacl.Spec.EC.Format.fst 01/30/2017 03:25 PM 31,046 Hacl.Spec.EC.Format.fst.hints 01/30/2017 03:25 PM 578 Hacl.Spec.EC.fst 01/30/2017 03:47 PM 3,668 Hacl.Spec.EC.Ladder.fst 01/30/2017 03:25 PM 7,644 Hacl.Spec.EC.Ladder.fst.hints 01/30/2017 03:25 PM 2,841 Hacl.Spec.EC.Point.fst 01/30/2017 03:25 PM 16,367 Hacl.Spec.EC.Point.fst.hints 01/30/2017 03:47 PM 2,384 Hacl.Test.X25519.fst 01/31/2017 08:54 AM 1,056 Hacl_Bignum.c 01/31/2017 08:54 AM 1,698 Hacl_Bignum.h 01/31/2017 08:54 AM 314 Hacl_Bignum_Constants.c 01/31/2017 08:54 AM 651 Hacl_Bignum_Constants.h 01/31/2017 08:54 AM 2,477 Hacl_Bignum_Crecip.c 01/31/2017 08:54 AM 1,273 Hacl_Bignum_Crecip.h 01/31/2017 08:54 AM 363 Hacl_Bignum_Fdifference.c 01/31/2017 08:54 AM 1,337 Hacl_Bignum_Fdifference.h 01/31/2017 08:54 AM 1,782 Hacl_Bignum_Fmul.c 01/31/2017 08:54 AM 1,594 Hacl_Bignum_Fmul.h 01/31/2017 08:54 AM 2,682 Hacl_Bignum_Fproduct.c 01/31/2017 08:54 AM 1,691 Hacl_Bignum_Fproduct.h 01/31/2017 08:54 AM 540 Hacl_Bignum_Fscalar.c 01/31/2017 08:54 AM 1,471 Hacl_Bignum_Fscalar.h 01/31/2017 08:54 AM 3,111 Hacl_Bignum_Fsquare.c 01/31/2017 08:54 AM 1,357 Hacl_Bignum_Fsquare.h 01/31/2017 08:54 AM 328 Hacl_Bignum_Fsum.c 01/31/2017 08:54 AM 1,112 Hacl_Bignum_Fsum.h 01/31/2017 08:54 AM 2,700 Hacl_Bignum_Limb.c 01/31/2017 08:54 AM 2,350 Hacl_Bignum_Limb.h 01/31/2017 08:54 AM 1,811 Hacl_Bignum_Modulo.c 01/31/2017 08:54 AM 1,480 Hacl_Bignum_Modulo.h 01/31/2017 08:54 AM 5,626 Hacl_Bignum_Parameters.c 01/31/2017 08:54 AM 4,634 Hacl_Bignum_Parameters.h 01/31/2017 08:54 AM 3,554 Hacl_Bignum_Wide.c 01/31/2017 08:54 AM 2,686 Hacl_Bignum_Wide.h 01/31/2017 08:54 AM 2,251 Hacl_Cast.c 01/31/2017 08:54 AM 1,602 Hacl_Cast.h 01/31/2017 08:54 AM 1,307 Hacl_EC.c 01/31/2017 08:54 AM 1,607 Hacl_EC.h 01/31/2017 08:54 AM 3,232 Hacl_EC_AddAndDouble.c 01/31/2017 08:54 AM 1,530 Hacl_EC_AddAndDouble.h 01/31/2017 08:54 AM 5,020 Hacl_EC_Format.c 01/31/2017 08:54 AM 1,545 Hacl_EC_Format.h 01/31/2017 08:54 AM 879 Hacl_EC_Ladder.c 01/31/2017 08:54 AM 1,983 Hacl_EC_Ladder.h 01/31/2017 08:54 AM 518 Hacl_EC_Ladder_BigLoop.c 01/31/2017 08:54 AM 1,651 Hacl_EC_Ladder_BigLoop.h 01/31/2017 08:54 AM 2,043 Hacl_EC_Ladder_SmallLoop.c 01/31/2017 08:54 AM 1,675 Hacl_EC_Ladder_SmallLoop.h 01/31/2017 08:54 AM 1,505 Hacl_EC_Point.c 01/31/2017 08:54 AM 1,728 Hacl_EC_Point.h 01/31/2017 08:54 AM 568 Hacl_Spec_Bignum.c 01/31/2017 08:54 AM 990 Hacl_Spec_Bignum.h 01/31/2017 08:54 AM 1,950 Hacl_Spec_Bignum_Bigint.c 01/31/2017 08:54 AM 1,800 Hacl_Spec_Bignum_Bigint.h 01/31/2017 08:54 AM 1,178 Hacl_Spec_Bignum_Crecip.c 01/31/2017 08:54 AM 1,511 Hacl_Spec_Bignum_Crecip.h 01/31/2017 08:54 AM 420 Hacl_Spec_Bignum_Fdifference.c 01/31/2017 08:54 AM 962 Hacl_Spec_Bignum_Fdifference.h 01/31/2017 08:54 AM 1,927 Hacl_Spec_Bignum_Field.c 01/31/2017 08:54 AM 2,058 Hacl_Spec_Bignum_Field.h 01/31/2017 08:54 AM 2,064 Hacl_Spec_Bignum_Fmul.c 01/31/2017 08:54 AM 2,147 Hacl_Spec_Bignum_Fmul.h 01/31/2017 08:54 AM 3,022 Hacl_Spec_Bignum_Fproduct.c 01/31/2017 08:54 AM 2,630 Hacl_Spec_Bignum_Fproduct.h 01/31/2017 08:54 AM 680 Hacl_Spec_Bignum_Fscalar.c 01/31/2017 08:54 AM 1,085 Hacl_Spec_Bignum_Fscalar.h 01/31/2017 08:54 AM 7,572 Hacl_Spec_Bignum_Fsquare.c 01/31/2017 08:54 AM 6,507 Hacl_Spec_Bignum_Fsquare.h 01/31/2017 08:54 AM 371 Hacl_Spec_Bignum_Fsum.c 01/31/2017 08:54 AM 949 Hacl_Spec_Bignum_Fsum.h 01/31/2017 08:54 AM 1,503 Hacl_Spec_Bignum_Modulo.c 01/31/2017 08:54 AM 1,480 Hacl_Spec_Bignum_Modulo.h 01/31/2017 08:54 AM 5,081 Hacl_Spec_EC_AddAndDouble.c 01/31/2017 08:54 AM 4,828 Hacl_Spec_EC_AddAndDouble.h 01/31/2017 08:54 AM 2,546 Hacl_Spec_EC_AddAndDouble2.c 01/31/2017 08:54 AM 2,543 Hacl_Spec_EC_AddAndDouble2.h 01/31/2017 08:54 AM 1,836 Hacl_Spec_EC_Format.c 01/31/2017 08:54 AM 1,899 Hacl_Spec_EC_Format.h 01/31/2017 08:54 AM 5,947 Hacl_Spec_EC_Ladder.c 01/31/2017 08:54 AM 2,741 Hacl_Spec_EC_Ladder.h 01/31/2017 08:54 AM 3,283 Hacl_Spec_EC_Point.c 01/31/2017 08:54 AM 2,593 Hacl_Spec_EC_Point.h 01/31/2017 08:54 AM 4,045 Hacl_Test_X25519.c 01/31/2017 08:54 AM 1,592 Hacl_Test_X25519.h 01/31/2017 08:54 AM 3,437 Hacl_UInt128.c 01/31/2017 08:54 AM 2,433 Hacl_UInt128.h 01/31/2017 08:54 AM 2,545 Hacl_UInt32.c 01/31/2017 08:54 AM 2,106 Hacl_UInt32.h 01/31/2017 08:54 AM 2,545 Hacl_UInt64.c 01/31/2017 08:54 AM 1,992 Hacl_UInt64.h 01/31/2017 08:54 AM 2,429 Hacl_UInt8.c 01/31/2017 08:54 AM 1,965 Hacl_UInt8.h 01/31/2017 09:15 AM 2,623 Makefile 01/31/2017 08:54 AM 26 Prims.c 01/31/2017 08:54 AM 126 Prims.h 01/31/2017 09:24 AM 119 test.c 01/31/2017 09:16 AM 234 test.cmi 01/31/2017 09:16 AM 287 test.cmx 01/31/2017 09:16 AM 42 test.ml 01/31/2017 09:16 AM 1,112 test.o 01/31/2017 08:55 AM x25519-c 01/31/2017 08:55 AM 654,423 x25519.exe 142 File(s) 2,767,109 bytes 3 Dir(s) 899,522,285,568 bytes freeNote that I'm running this within a Windows shell to rule out Cygwin behavior.
Note also:
D:\cygwin\home\protz\Code\hacl-star\code\curve25519>type test.c #include int main(int argc, char *argv[]) { for (int i = 0; i < argc; ++i) printf("%s\n", argv[i]); } D:\cygwin\home\protz\Code\hacl-star\code\curve25519>.\a.exe Hacl.Spec.* .\a.exe Hacl.Spec.*The text was updated successfully, but these errors were encountered: