Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore lists some files that should not be ignored #7509

Closed
vicuna opened this issue Mar 25, 2017 · 6 comments
Closed

.gitignore lists some files that should not be ignored #7509

vicuna opened this issue Mar 25, 2017 · 6 comments

Comments

@vicuna
Copy link

vicuna commented Mar 25, 2017

Original bug ID: 7509
Reporter: @kenichi-asai
Status: resolved (set by @dra27 on 2017-10-12T10:50:02Z)
Resolution: open
Priority: low
Severity: tweak
Platform: Apple
OS: MacOS X
OS Version: 10.12
Version: 4.04.0
Target version: 4.07.0+dev/beta2/rc1/rc2
Fixed in version: 4.07.0+dev/beta2/rc1/rc2
Category: configure and build/install

Bug description

The following files exist in the distribution:

.depend
/otherlibs/systhreads/thread.ml
/testsuite/tests/asmcomp/mips.s
/testsuite/tests/opaque/intf/opaque_impl.mli
/testsuite/tests/opaque/intf/opaque_intf.mli
/testsuite/tests/opaque/intf/regular.mli

but they match the pattern in .gitignore. As such, if one creates a fresh git repository from the distribution, they are ignored in the repository, resulting in a failure when doing "make world".

@vicuna
Copy link
Author

vicuna commented Mar 26, 2017

Comment author: @xavierleroy

This is wrong indeed and will be fixed soon. Just one question:

I don't see which pattern '.depend' matches. Could you show me?

@vicuna
Copy link
Author

vicuna commented Mar 27, 2017

Comment author: @kenichi-asai

I have to add .depend.nt to the list of ignored files. See below for all the matches.

% cat go.sh
sed -e 's/^([^#/].)$/find . -name "\1" -print/'
-e 's/^/(.
)$/ls \1 2> /dev/null/'
% cd ocaml-4.04.0/
% cat .gitignore | bash ../go.sh > ../script
% bash ../script
./.depend
./asmrun/.depend
./byterun/.depend
./debugger/.depend
./lex/.depend
./ocamldoc/.depend
./otherlibs/bigarray/.depend
./otherlibs/graph/.depend
./otherlibs/num/.depend
./otherlibs/raw_spacetime_lib/.depend
./otherlibs/str/.depend
./otherlibs/systhreads/.depend
./otherlibs/threads/.depend
./otherlibs/unix/.depend
./otherlibs/win32unix/.depend
./stdlib/.depend
./tools/.depend
./otherlibs/num/.depend.nt
otherlibs/systhreads/thread.ml
testsuite/tests/asmcomp/mips.s
testsuite/tests/opaque/intf/opaque_impl.mli
testsuite/tests/opaque/intf/opaque_intf.mli
testsuite/tests/opaque/intf/regular.mli

@vicuna
Copy link
Author

vicuna commented Mar 27, 2017

Comment author: @xavierleroy

Thanks for the incantations. But this still doesn't help me find which line in .gitignore would cause .depend files to be ignored.

@vicuna
Copy link
Author

vicuna commented Mar 27, 2017

Comment author: @kenichi-asai

Oh, I see. At line 30 (and ".depend.nt" at line 31) of .gitignore.

@vicuna
Copy link
Author

vicuna commented Mar 27, 2017

Comment author: @xavierleroy

Thanks, and apologies for being thick: I was looking at the trunk version of .gitignore where the .depend patterns have been removed already.

@vicuna
Copy link
Author

vicuna commented Oct 12, 2017

Comment author: @dra27

This incantation is somewhat more informative, but you need a clean git clone:

find . -type f | git check-ignore --no-index --stdin --verbose

You will get a false-positive line:

compilerlibs/.gitignore:7:!.gitignore   ./compilerlibs/.gitignore

from what appears to be a bug in git-check-ignore and, on Windows, false-positives for testsuite/tests/asmgen/*.S (because the .s rule incorrectly applies on a case-preserving file system), but otherwise this should be empty.

For the completeness' sake, I pushed 41510b0 which makes the opaque test ignore explicit.

@vicuna vicuna closed this as completed Oct 12, 2017
@vicuna vicuna added this to the 4.07.0 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant