Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position information for diagnostics by the OCaml linking software #7568

Closed
vicuna opened this issue Jun 26, 2017 · 4 comments
Closed

Fix position information for diagnostics by the OCaml linking software #7568

vicuna opened this issue Jun 26, 2017 · 4 comments

Comments

@vicuna
Copy link

vicuna commented Jun 26, 2017

Original bug ID: 7568
Reporter: @elfring
Status: acknowledged (set by @dra27 on 2017-06-26T16:55:22Z)
Resolution: open
Priority: normal
Severity: tweak
Platform: openSUSE Tumbleweed
Version: 4.03.0
Category: compiler driver
Tags: junior_job
Related to: #7566
Monitored by: @hcarty

Bug description

I tried a software development approach out where I adjusted some variables in build scripts. This had the “side effect” (for a moment) that an order of object files was chosen for an executable file which the OCaml linker did not like.

The error message contained the information “File "none", line 1:”. I suggest to improve the software diagnostics around such places.

This request is the continuation for a detail from my previous bug report “Checking processes for resolving of references from module implementations by the OCaml linker”.

Additional information

#7566#c17997

@vicuna
Copy link
Author

vicuna commented Jun 26, 2017

Comment author: @dra27

Request is to eliminate the sentinel location value in transcripts such as:

/usr/bin/ocamlopt.opt … -o spatch.opt … ctl/ctl.cmxa …
File "_none_", line 1:
Error: No implementations provided for the following modules:
         Pretty_print_ctl referenced from ctl/ctl.cmxa(Ctl_engine)

(for example, either not displaying the File line, or including a different message such as "Linker error")

@elfring
Copy link

elfring commented Apr 15, 2019

I am still curious how affected software components will be improved also for this issue.

@damiendoligez
Copy link
Member

The File line should not be eliminated because it marks the beginning of the error message that can be automatically recognized by tools such as emacs.

Whatever you do to this line, in the end it must match one of the regular expressions used by emacs to parse error messages. In practice that means you can only change the file name (the part between quotes) and the line number.

@github-actions
Copy link

github-actions bot commented Aug 3, 2020

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

@github-actions github-actions bot added the Stale label Aug 3, 2020
@github-actions github-actions bot closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants